瀏覽代碼

Merge pull request #16804 from Microsoft/jjh/fixpullimageifnotexist

No err shadowing on pullImageIfNotExist
Vincent Demeester 9 年之前
父節點
當前提交
aee0fcf413
共有 1 個文件被更改,包括 3 次插入3 次删除
  1. 3 3
      integration-cli/docker_utils.go

+ 3 - 3
integration-cli/docker_utils.go

@@ -609,16 +609,16 @@ func imageExists(image string) error {
 	return err
 }
 
-func pullImageIfNotExist(image string) (err error) {
+func pullImageIfNotExist(image string) error {
 	if err := imageExists(image); err != nil {
 		pullCmd := exec.Command(dockerBinary, "pull", image)
 		_, exitCode, err := runCommandWithOutput(pullCmd)
 
 		if err != nil || exitCode != 0 {
-			err = fmt.Errorf("image %q wasn't found locally and it couldn't be pulled: %s", image, err)
+			return fmt.Errorf("image %q wasn't found locally and it couldn't be pulled: %s", image, err)
 		}
 	}
-	return
+	return nil
 }
 
 func dockerCmdWithError(args ...string) (string, int, error) {