浏览代码

Add explicit status response to OPTIONS handler

Write the http.StatusOK header in the OPTIONS
handler and update the unit tests to refer to the
response code using the const from the http package.
Michael Crosby 12 年之前
父节点
当前提交
ac599d6528
共有 2 个文件被更改,包括 3 次插入2 次删除
  1. 1 0
      api.go
  2. 2 2
      api_test.go

+ 1 - 0
api.go

@@ -793,6 +793,7 @@ func createRouter(srv *Server, logging bool) (*mux.Router, error) {
 		if srv.enableCors {
 		if srv.enableCors {
 			writeCorsHeaders(w, r)
 			writeCorsHeaders(w, r)
 		}
 		}
+		w.WriteHeader(http.StatusOK)
 	})
 	})
 	return r, nil
 	return r, nil
 }
 }

+ 2 - 2
api_test.go

@@ -1260,7 +1260,7 @@ func TestOptionsRoute(t *testing.T) {
 	}
 	}
 
 
 	router.ServeHTTP(r, req)
 	router.ServeHTTP(r, req)
-	if r.Code != 200 {
+	if r.Code != http.StatusOK {
 		t.Errorf("Expected response for OPTIONS request to be \"200\", %v found.", r.Code)
 		t.Errorf("Expected response for OPTIONS request to be \"200\", %v found.", r.Code)
 	}
 	}
 }
 }
@@ -1287,7 +1287,7 @@ func TestGetEnabledCors(t *testing.T) {
 	}
 	}
 
 
 	router.ServeHTTP(r, req)
 	router.ServeHTTP(r, req)
-	if r.Code != 200 {
+	if r.Code != http.StatusOK {
 		t.Errorf("Expected response for OPTIONS request to be \"200\", %v found.", r.Code)
 		t.Errorf("Expected response for OPTIONS request to be \"200\", %v found.", r.Code)
 	}
 	}