Selaa lähdekoodia

change exportImage to top-level func

Signed-off-by: Kun Zhang <zkazure@gmail.com>

remove useless FIXME

Signed-off-by: Kun Zhang <zkazure@gmail.com>

fix

Signed-off-by: Kun Zhang <zkazure@gmail.com>
Kun Zhang 10 vuotta sitten
vanhempi
commit
a7c00bc1a2
2 muutettua tiedostoa jossa 0 lisäystä ja 2 poistoa
  1. 0 1
      graph/export.go
  2. 0 1
      pkg/parsers/parsers.go

+ 0 - 1
graph/export.go

@@ -105,7 +105,6 @@ func (s *TagStore) ImageExport(names []string, outStream io.Writer) error {
 	return nil
 	return nil
 }
 }
 
 
-// FIXME: this should be a top-level function, not a class method
 func (s *TagStore) exportImage(name, tempdir string) error {
 func (s *TagStore) exportImage(name, tempdir string) error {
 	for n := name; n != ""; {
 	for n := name; n != ""; {
 		// temporary directory
 		// temporary directory

+ 0 - 1
pkg/parsers/parsers.go

@@ -14,7 +14,6 @@ import (
 
 
 // ParseHost parses the specified address and returns an address that will be used as the host.
 // ParseHost parses the specified address and returns an address that will be used as the host.
 // Depending of the address specified, will use the defaultTCPAddr or defaultUnixAddr
 // Depending of the address specified, will use the defaultTCPAddr or defaultUnixAddr
-// FIXME: Change this not to receive default value as parameter
 func ParseHost(defaultTCPAddr, defaultUnixAddr, addr string) (string, error) {
 func ParseHost(defaultTCPAddr, defaultUnixAddr, addr string) (string, error) {
 	addr = strings.TrimSpace(addr)
 	addr = strings.TrimSpace(addr)
 	if addr == "" {
 	if addr == "" {