فهرست منبع

integration/secret: fix TestSecretInspect not actually checking response

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 5 سال پیش
والد
کامیت
a45c89ecd1
1فایلهای تغییر یافته به همراه7 افزوده شده و 5 حذف شده
  1. 7 5
      integration/secret/secret_test.go

+ 7 - 5
integration/secret/secret_test.go

@@ -3,6 +3,7 @@ package secret // import "github.com/docker/docker/integration/secret"
 import (
 import (
 	"bytes"
 	"bytes"
 	"context"
 	"context"
+	"encoding/json"
 	"sort"
 	"sort"
 	"testing"
 	"testing"
 	"time"
 	"time"
@@ -30,16 +31,17 @@ func TestSecretInspect(t *testing.T) {
 
 
 	ctx := context.Background()
 	ctx := context.Background()
 
 
-	testName := "test_secret_" + t.Name()
+	testName := t.Name()
 	secretID := createSecret(ctx, t, c, testName, []byte("TESTINGDATA"), nil)
 	secretID := createSecret(ctx, t, c, testName, []byte("TESTINGDATA"), nil)
 
 
-	secret, _, err := c.SecretInspectWithRaw(context.Background(), secretID)
+	insp, body, err := c.SecretInspectWithRaw(ctx, secretID)
 	assert.NilError(t, err)
 	assert.NilError(t, err)
-	assert.Check(t, is.Equal(secret.Spec.Name, testName))
+	assert.Check(t, is.Equal(insp.Spec.Name, testName))
 
 
-	secret, _, err = c.SecretInspectWithRaw(context.Background(), testName)
+	var secret swarmtypes.Secret
+	err = json.Unmarshal(body, &secret)
 	assert.NilError(t, err)
 	assert.NilError(t, err)
-	assert.Check(t, is.Equal(secretID, secretID))
+	assert.Check(t, is.DeepEqual(secret, insp))
 }
 }
 
 
 func TestSecretList(t *testing.T) {
 func TestSecretList(t *testing.T) {