diff --git a/libnetwork/controller.go b/libnetwork/controller.go index 1f81c88f9e..a646281e7c 100644 --- a/libnetwork/controller.go +++ b/libnetwork/controller.go @@ -163,7 +163,7 @@ func New(cfgOptions ...config.Option) (NetworkController, error) { log.Debugf("Failed to Initialize Discovery : %v", err) } if err := c.initLocalStore(); err != nil { - return nil, fmt.Errorf("Failed to Initialize LocalDatastore due to %v.", err) + log.Debugf("Failed to Initialize LocalDatastore due to %v.", err) } } diff --git a/libnetwork/drivers/bridge/bridge.go b/libnetwork/drivers/bridge/bridge.go index a8d86c844c..87380101dd 100644 --- a/libnetwork/drivers/bridge/bridge.go +++ b/libnetwork/drivers/bridge/bridge.go @@ -48,18 +48,18 @@ type configuration struct { // networkConfiguration for network specific configuration type networkConfiguration struct { - BridgeName string - AddressIPv4 *net.IPNet - FixedCIDR *net.IPNet - FixedCIDRv6 *net.IPNet - EnableIPv6 bool - EnableIPMasquerade bool - EnableICC bool - Mtu int - DefaultGatewayIPv4 net.IP - DefaultGatewayIPv6 net.IP - DefaultBindingIP net.IP - DisableBridgeCreation bool + BridgeName string + AddressIPv4 *net.IPNet + FixedCIDR *net.IPNet + FixedCIDRv6 *net.IPNet + EnableIPv6 bool + EnableIPMasquerade bool + EnableICC bool + Mtu int + DefaultGatewayIPv4 net.IP + DefaultGatewayIPv6 net.IP + DefaultBindingIP net.IP + DefaultBridge bool } // endpointConfiguration represents the user specified configuration for the sandbox endpoint @@ -249,13 +249,13 @@ func (c *networkConfiguration) fromMap(data map[string]interface{}) error { } } - if i, ok := data["DisableBridgeCreation"]; ok && i != nil { + if i, ok := data["DefaultBridge"]; ok && i != nil { if s, ok := i.(string); ok { - if c.DisableBridgeCreation, err = strconv.ParseBool(s); err != nil { - return types.BadRequestErrorf("failed to parse DisableBridgeCreation value: %s", err.Error()) + if c.DefaultBridge, err = strconv.ParseBool(s); err != nil { + return types.BadRequestErrorf("failed to parse DefaultBridge value: %s", err.Error()) } } else { - return types.BadRequestErrorf("invalid type for DisableBridgeCreation value") + return types.BadRequestErrorf("invalid type for DefaultBridge value") } } @@ -537,7 +537,7 @@ func parseNetworkOptions(id string, option options.Generic) (*networkConfigurati return nil, err } - if config.BridgeName == "" && config.DisableBridgeCreation == false { + if config.BridgeName == "" && config.DefaultBridge == false { config.BridgeName = "br-" + id[:12] } return config, nil diff --git a/libnetwork/drivers/bridge/bridge_test.go b/libnetwork/drivers/bridge/bridge_test.go index 442440ad7e..8f53208418 100644 --- a/libnetwork/drivers/bridge/bridge_test.go +++ b/libnetwork/drivers/bridge/bridge_test.go @@ -123,7 +123,7 @@ func TestCreateFail(t *testing.T) { t.Fatalf("Failed to setup driver config: %v", err) } - netconfig := &networkConfiguration{BridgeName: "dummy0", DisableBridgeCreation: true} + netconfig := &networkConfiguration{BridgeName: "dummy0", DefaultBridge: true} genericOption := make(map[string]interface{}) genericOption[netlabel.GenericData] = netconfig diff --git a/libnetwork/drivers/bridge/setup_device.go b/libnetwork/drivers/bridge/setup_device.go index 50f01b8270..ddd9e452d0 100644 --- a/libnetwork/drivers/bridge/setup_device.go +++ b/libnetwork/drivers/bridge/setup_device.go @@ -15,7 +15,7 @@ func setupDevice(config *networkConfiguration, i *bridgeInterface) error { // We only attempt to create the bridge when the requested device name is // the default one. - if config.BridgeName != DefaultBridgeName && config.DisableBridgeCreation { + if config.BridgeName != DefaultBridgeName && config.DefaultBridge { return NonDefaultBridgeExistError(config.BridgeName) } diff --git a/libnetwork/drivers/bridge/setup_device_test.go b/libnetwork/drivers/bridge/setup_device_test.go index 235260c559..aaaed15a32 100644 --- a/libnetwork/drivers/bridge/setup_device_test.go +++ b/libnetwork/drivers/bridge/setup_device_test.go @@ -33,7 +33,7 @@ func TestSetupNewBridge(t *testing.T) { func TestSetupNewNonDefaultBridge(t *testing.T) { defer testutils.SetupTestOSContext(t)() - config := &networkConfiguration{BridgeName: "test0", DisableBridgeCreation: true} + config := &networkConfiguration{BridgeName: "test0", DefaultBridge: true} br := &bridgeInterface{} err := setupDevice(config, br) diff --git a/libnetwork/drivers/bridge/setup_ipv4.go b/libnetwork/drivers/bridge/setup_ipv4.go index 59ae06511f..e63c18df21 100644 --- a/libnetwork/drivers/bridge/setup_ipv4.go +++ b/libnetwork/drivers/bridge/setup_ipv4.go @@ -53,7 +53,7 @@ func setupBridgeIPv4(config *networkConfiguration, i *bridgeInterface) error { // Do not try to configure IPv4 on a non-default bridge unless you are // specifically asked to do so. - if config.BridgeName != DefaultBridgeName && config.DisableBridgeCreation { + if config.BridgeName != DefaultBridgeName && config.DefaultBridge { return NonDefaultBridgeNeedsIPError(config.BridgeName) } diff --git a/libnetwork/sandbox_externalkey.go b/libnetwork/sandbox_externalkey.go index fe863495ab..0b2385b3bf 100644 --- a/libnetwork/sandbox_externalkey.go +++ b/libnetwork/sandbox_externalkey.go @@ -138,7 +138,7 @@ func (c *controller) acceptClientConnections(sock string, l net.Listener) { conn, err := l.Accept() if err != nil { if _, err1 := os.Stat(sock); os.IsNotExist(err1) { - logrus.Warnf("Unix socket %s doesnt exist. cannot accept client connections", sock) + logrus.Debugf("Unix socket %s doesnt exist. cannot accept client connections", sock) return } logrus.Errorf("Error accepting connection %v", err) diff --git a/libnetwork/store_test.go b/libnetwork/store_test.go index f4aeebd792..ec1da287ba 100644 --- a/libnetwork/store_test.go +++ b/libnetwork/store_test.go @@ -133,14 +133,18 @@ func TestLocalStoreLockTimeout(t *testing.T) { if err != nil { t.Fatalf("Error getting random boltdb configs %v", err) } - ctrl, err := New(cfgOptions...) + ctrl1, err := New(cfgOptions...) if err != nil { t.Fatalf("Error new controller: %v", err) } - defer ctrl.Stop() + defer ctrl1.Stop() // Use the same boltdb file without closing the previous controller - _, err = New(cfgOptions...) - if err == nil { - t.Fatalf("Multiple boldtdb connection must fail") + ctrl2, _ := New(cfgOptions...) + if err != nil { + t.Fatalf("Error new controller: %v", err) + } + store := ctrl2.(*controller).localStore + if store != nil { + t.Fatalf("localstore is expected to be nil") } }