浏览代码

Merge pull request #22 from shykes/shykes-0.6.5-dm-plugin

Fix ImageTree test
Michael Crosby 11 年之前
父节点
当前提交
a06edd77e5
共有 2 个文件被更改,包括 12 次插入11 次删除
  1. 8 6
      commands.go
  2. 4 5
      commands_test.go

+ 8 - 6
commands.go

@@ -1100,16 +1100,18 @@ func (cli *DockerCli) CmdImages(args ...string) error {
 		}
 		}
 
 
 		var outs []APIImages
 		var outs []APIImages
-		err = json.Unmarshal(body, &outs)
-		if err != nil {
+		if err := json.Unmarshal(body, &outs); err != nil {
 			return err
 			return err
 		}
 		}
 
 
-		var startImageArg = cmd.Arg(0)
-		var startImage APIImages
+		var (
+			startImageArg = cmd.Arg(0)
+			startImage    APIImages
+
+			roots    []APIImages
+			byParent = make(map[string][]APIImages)
+		)
 
 
-		var roots []APIImages
-		var byParent = make(map[string][]APIImages)
 		for _, image := range outs {
 		for _, image := range outs {
 			if image.ParentId == "" {
 			if image.ParentId == "" {
 				roots = append(roots, image)
 				roots = append(roots, image)

+ 4 - 5
commands_test.go

@@ -776,13 +776,12 @@ func TestImagesTree(t *testing.T) {
 			t.Fatal(err)
 			t.Fatal(err)
 		}
 		}
 		cmdOutput := string(cmdOutputBytes)
 		cmdOutput := string(cmdOutputBytes)
-
 		regexpStrings := []string{
 		regexpStrings := []string{
 			fmt.Sprintf("└─%s Size: (\\d+.\\d+ MB) \\(virtual \\d+.\\d+ MB\\) Tags: %s:latest", unitTestImageIDShort, unitTestImageName),
 			fmt.Sprintf("└─%s Size: (\\d+.\\d+ MB) \\(virtual \\d+.\\d+ MB\\) Tags: %s:latest", unitTestImageIDShort, unitTestImageName),
-			"(?m)^  └─[0-9a-f]+",
-			"(?m)^    └─[0-9a-f]+",
-			"(?m)^      └─[0-9a-f]+",
-			fmt.Sprintf("        └─%s Size: \\d+ B \\(virtual \\d+.\\d+ MB\\) Tags: test:latest", utils.TruncateID(image.ID)),
+			"(?m)   └─[0-9a-f]+.*",
+			"(?m)    └─[0-9a-f]+.*",
+			"(?m)      └─[0-9a-f]+.*",
+			fmt.Sprintf("(?m)^        └─%s Size: \\d+.\\d+ MB \\(virtual \\d+.\\d+ MB\\) Tags: test:latest", utils.TruncateID(image.ID)),
 		}
 		}
 
 
 		compiledRegexps := []*regexp.Regexp{}
 		compiledRegexps := []*regexp.Regexp{}