Jelajahi Sumber

Close pipe if mountFrom failed.

Signed-off-by: Shukui Yang <yangshukui@huawei.com>
Shukui Yang 7 tahun lalu
induk
melakukan
9f38923901
1 mengubah file dengan 3 tambahan dan 2 penghapusan
  1. 3 2
      daemon/graphdriver/overlay2/mount.go

+ 3 - 2
daemon/graphdriver/overlay2/mount.go

@@ -49,18 +49,19 @@ func mountFrom(dir, device, target, mType string, flags uintptr, label string) e
 	output := bytes.NewBuffer(nil)
 	cmd.Stdout = output
 	cmd.Stderr = output
-
 	if err := cmd.Start(); err != nil {
+		w.Close()
 		return fmt.Errorf("mountfrom error on re-exec cmd: %v", err)
 	}
 	//write the options to the pipe for the untar exec to read
 	if err := json.NewEncoder(w).Encode(options); err != nil {
+		w.Close()
 		return fmt.Errorf("mountfrom json encode to pipe failed: %v", err)
 	}
 	w.Close()
 
 	if err := cmd.Wait(); err != nil {
-		return fmt.Errorf("mountfrom re-exec error: %v: output: %s", err, output)
+		return fmt.Errorf("mountfrom re-exec error: %v: output: %v", err, output)
 	}
 	return nil
 }