diff --git a/pkg/archive/archive.go b/pkg/archive/archive.go index f521388d1ffee6985b5ab903742a085d405905c5..194d76a8c7ebb934a287f911cacb06fb7376c3bc 100644 --- a/pkg/archive/archive.go +++ b/pkg/archive/archive.go @@ -145,7 +145,7 @@ func DetectCompression(source []byte) Compression { logrus.Debug("Len too short") continue } - if bytes.Compare(m, source[:len(m)]) == 0 { + if bytes.Equal(m, source[:len(m)]) { return compression } } diff --git a/pkg/archive/archive_unix.go b/pkg/archive/archive_unix.go index d94858887d5fa8e39db16e8e3f3b8505086512b3..68d3c97d274f581a51c93b39d0e6b0f919dec7d9 100644 --- a/pkg/archive/archive_unix.go +++ b/pkg/archive/archive_unix.go @@ -107,10 +107,7 @@ func handleTarTypeBlockCharFifo(hdr *tar.Header, path string) error { mode |= syscall.S_IFIFO } - if err := system.Mknod(path, mode, int(system.Mkdev(hdr.Devmajor, hdr.Devminor))); err != nil { - return err - } - return nil + return system.Mknod(path, mode, int(system.Mkdev(hdr.Devmajor, hdr.Devminor))) } func handleLChmod(hdr *tar.Header, path string, hdrInfo os.FileInfo) error { diff --git a/pkg/archive/changes.go b/pkg/archive/changes.go index c07d55cbd9a762c9495b8f4d7f2b6d627acb88df..ca2c0ca1bfd9d2c558c811d98a93fb45484da1b0 100644 --- a/pkg/archive/changes.go +++ b/pkg/archive/changes.go @@ -267,7 +267,7 @@ func (info *FileInfo) addChanges(oldInfo *FileInfo, changes *[]Change) { } for name, newChild := range info.children { - oldChild, _ := oldChildren[name] + oldChild := oldChildren[name] if oldChild != nil { // change? oldStat := oldChild.stat @@ -279,7 +279,7 @@ func (info *FileInfo) addChanges(oldInfo *FileInfo, changes *[]Change) { // breaks down is if some code intentionally hides a change by setting // back mtime if statDifferent(oldStat, newStat) || - bytes.Compare(oldChild.capability, newChild.capability) != 0 { + !bytes.Equal(oldChild.capability, newChild.capability) { change := Change{ Path: newChild.path(), Kind: ChangeModify, diff --git a/pkg/chrootarchive/archive_test.go b/pkg/chrootarchive/archive_test.go index d2d7e621f52f5e64ccf2c356a317f633a799ed9b..80e54a0edc06a11862d5a5c7782928e44497f300 100644 --- a/pkg/chrootarchive/archive_test.go +++ b/pkg/chrootarchive/archive_test.go @@ -77,7 +77,7 @@ func TestChrootUntarWithHugeExcludesList(t *testing.T) { options := &archive.TarOptions{} //65534 entries of 64-byte strings ~= 4MB of environment space which should overflow //on most systems when passed via environment or command line arguments - excludes := make([]string, 65534, 65534) + excludes := make([]string, 65534) for i := 0; i < 65534; i++ { excludes[i] = strings.Repeat(string(i), 64) } diff --git a/pkg/filenotify/poller.go b/pkg/filenotify/poller.go index 0f4c4dc7ba538e9f103973be47d217f6f1decbfd..b90111bb4fc5f31ca52d5876b18ff12d35f81542 100644 --- a/pkg/filenotify/poller.go +++ b/pkg/filenotify/poller.go @@ -44,7 +44,7 @@ func (w *filePoller) Add(name string) error { w.mu.Lock() defer w.mu.Unlock() - if w.closed == true { + if w.closed { return errPollerClosed } @@ -78,7 +78,7 @@ func (w *filePoller) Remove(name string) error { } func (w *filePoller) remove(name string) error { - if w.closed == true { + if w.closed { return errPollerClosed } diff --git a/pkg/fileutils/fileutils_test.go b/pkg/fileutils/fileutils_test.go index 0d543923760f6d4b49da44e2719466e15627eda9..4b178a16bb9d7fd554cf1c86a36dceff6e9344f6 100644 --- a/pkg/fileutils/fileutils_test.go +++ b/pkg/fileutils/fileutils_test.go @@ -208,7 +208,7 @@ func TestReadSymlinkedDirectoryToFile(t *testing.T) { func TestWildcardMatches(t *testing.T) { match, _ := Matches("fileutils.go", []string{"*"}) - if match != true { + if !match { t.Errorf("failed to get a wildcard match, got %v", match) } } @@ -216,7 +216,7 @@ func TestWildcardMatches(t *testing.T) { // A simple pattern match should return true. func TestPatternMatches(t *testing.T) { match, _ := Matches("fileutils.go", []string{"*.go"}) - if match != true { + if !match { t.Errorf("failed to get a match, got %v", match) } } @@ -224,7 +224,7 @@ func TestPatternMatches(t *testing.T) { // An exclusion followed by an inclusion should return true. func TestExclusionPatternMatchesPatternBefore(t *testing.T) { match, _ := Matches("fileutils.go", []string{"!fileutils.go", "*.go"}) - if match != true { + if !match { t.Errorf("failed to get true match on exclusion pattern, got %v", match) } } @@ -232,7 +232,7 @@ func TestExclusionPatternMatchesPatternBefore(t *testing.T) { // A folder pattern followed by an exception should return false. func TestPatternMatchesFolderExclusions(t *testing.T) { match, _ := Matches("docs/README.md", []string{"docs", "!docs/README.md"}) - if match != false { + if match { t.Errorf("failed to get a false match on exclusion pattern, got %v", match) } } @@ -240,7 +240,7 @@ func TestPatternMatchesFolderExclusions(t *testing.T) { // A folder pattern followed by an exception should return false. func TestPatternMatchesFolderWithSlashExclusions(t *testing.T) { match, _ := Matches("docs/README.md", []string{"docs/", "!docs/README.md"}) - if match != false { + if match { t.Errorf("failed to get a false match on exclusion pattern, got %v", match) } } @@ -248,7 +248,7 @@ func TestPatternMatchesFolderWithSlashExclusions(t *testing.T) { // A folder pattern followed by an exception should return false. func TestPatternMatchesFolderWildcardExclusions(t *testing.T) { match, _ := Matches("docs/README.md", []string{"docs/*", "!docs/README.md"}) - if match != false { + if match { t.Errorf("failed to get a false match on exclusion pattern, got %v", match) } } @@ -256,7 +256,7 @@ func TestPatternMatchesFolderWildcardExclusions(t *testing.T) { // A pattern followed by an exclusion should return false. func TestExclusionPatternMatchesPatternAfter(t *testing.T) { match, _ := Matches("fileutils.go", []string{"*.go", "!fileutils.go"}) - if match != false { + if match { t.Errorf("failed to get false match on exclusion pattern, got %v", match) } } @@ -264,7 +264,7 @@ func TestExclusionPatternMatchesPatternAfter(t *testing.T) { // A filename evaluating to . should return false. func TestExclusionPatternMatchesWholeDirectory(t *testing.T) { match, _ := Matches(".", []string{"*.go"}) - if match != false { + if match { t.Errorf("failed to get false match on ., got %v", match) } } @@ -573,7 +573,7 @@ func TestMatch(t *testing.T) { pattern := tt.pattern s := tt.s if runtime.GOOS == "windows" { - if strings.Index(pattern, "\\") >= 0 { + if strings.Contains(pattern, "\\") { // no escape allowed on windows. continue } diff --git a/pkg/ioutils/fswriters_test.go b/pkg/ioutils/fswriters_test.go index c4d1419306a4706a968806235e020ee7e7e08294..5d286005d20dbf3b4ac27b85a3555889ea00716f 100644 --- a/pkg/ioutils/fswriters_test.go +++ b/pkg/ioutils/fswriters_test.go @@ -37,7 +37,7 @@ func TestAtomicWriteToFile(t *testing.T) { t.Fatalf("Error reading from file: %v", err) } - if bytes.Compare(actual, expected) != 0 { + if !bytes.Equal(actual, expected) { t.Fatalf("Data mismatch, expected %q, got %q", expected, actual) } @@ -85,7 +85,7 @@ func TestAtomicWriteSetCommit(t *testing.T) { t.Fatalf("Error reading from file: %v", err) } - if bytes.Compare(actual, expected) != 0 { + if !bytes.Equal(actual, expected) { t.Fatalf("Data mismatch, expected %q, got %q", expected, actual) } diff --git a/pkg/ioutils/multireader_test.go b/pkg/ioutils/multireader_test.go index 65309a956530b385a5c687f653b207a516a1dc89..86ce47a22644870163a27b2126914714b67075d0 100644 --- a/pkg/ioutils/multireader_test.go +++ b/pkg/ioutils/multireader_test.go @@ -193,7 +193,7 @@ func TestMultiReadSeekerCurAfterSet(t *testing.T) { func TestMultiReadSeekerSmallReads(t *testing.T) { readers := []io.ReadSeeker{} for i := 0; i < 10; i++ { - integer := make([]byte, 4, 4) + integer := make([]byte, 4) binary.BigEndian.PutUint32(integer, uint32(i)) readers = append(readers, bytes.NewReader(integer)) } diff --git a/pkg/jsonlog/jsonlogbytes.go b/pkg/jsonlog/jsonlogbytes.go index df522c0d66f5c4ca4113faa30f8995899ff69ae2..0ba716f2611c017e617c2623b42fae6e6dcf9667 100644 --- a/pkg/jsonlog/jsonlogbytes.go +++ b/pkg/jsonlog/jsonlogbytes.go @@ -30,7 +30,7 @@ func (mj *JSONLogs) MarshalJSONBuf(buf *bytes.Buffer) error { ffjsonWriteJSONBytesAsString(buf, mj.Log) } if len(mj.Stream) != 0 { - if first == true { + if first { first = false } else { buf.WriteString(`,`) diff --git a/pkg/listeners/group_unix.go b/pkg/listeners/group_unix.go index c48707935542602ff32e03913f186fb46597d472..e1d8774caeabda56546917d803ed10b249f554ae 100644 --- a/pkg/listeners/group_unix.go +++ b/pkg/listeners/group_unix.go @@ -23,7 +23,7 @@ func lookupGID(name string) (int, error) { if err != nil { return -1, errors.Wrapf(err, "error parsing groups for %s", name) } - if groups != nil && len(groups) > 0 { + if len(groups) > 0 { return groups[0].Gid, nil } gid, err := strconv.Atoi(name) diff --git a/pkg/mount/mount.go b/pkg/mount/mount.go index 66ac4bf4723ef2c3b01e9fdfa65bbc5c619cefb3..bb4cd887f7e24a533417bef1ef8077defac52fd3 100644 --- a/pkg/mount/mount.go +++ b/pkg/mount/mount.go @@ -46,10 +46,7 @@ func Mount(device, target, mType, options string) error { // flags.go for supported option flags. func ForceMount(device, target, mType, options string) error { flag, data := parseOptions(options) - if err := mount(device, target, mType, uintptr(flag), data); err != nil { - return err - } - return nil + return mount(device, target, mType, uintptr(flag), data) } // Unmount will unmount the target filesystem, so long as it is mounted. diff --git a/pkg/plugins/discovery_test.go b/pkg/plugins/discovery_test.go index 03f9d003194607a0aafc65df66a342b729efd2ac..1a23faaead1e13fd391b77950af9a4875a20443b 100644 --- a/pkg/plugins/discovery_test.go +++ b/pkg/plugins/discovery_test.go @@ -66,7 +66,7 @@ func TestFileSpecPlugin(t *testing.T) { t.Fatalf("Expected plugin addr `%s`, got %s\n", c.addr, p.Addr) } - if p.TLSConfig.InsecureSkipVerify != true { + if !p.TLSConfig.InsecureSkipVerify { t.Fatalf("Expected TLS verification to be skipped") } } diff --git a/pkg/plugins/discovery_unix_test.go b/pkg/plugins/discovery_unix_test.go index 3e2d506b9755bfb2d5e7478f89fa4232b64aba6f..1b232b7ade411ff44a69ef4e7a1cde0c8b06ae6e 100644 --- a/pkg/plugins/discovery_unix_test.go +++ b/pkg/plugins/discovery_unix_test.go @@ -53,7 +53,7 @@ func TestLocalSocket(t *testing.T) { if p.Addr != addr { t.Fatalf("Expected plugin addr `%s`, got %s\n", addr, p.Addr) } - if p.TLSConfig.InsecureSkipVerify != true { + if !p.TLSConfig.InsecureSkipVerify { t.Fatalf("Expected TLS verification to be skipped") } l.Close() diff --git a/pkg/progress/progressreader_test.go b/pkg/progress/progressreader_test.go index b14d4015614aa1bf9c9aeae1264959b91c73834c..690e70596892d2eecf336f2e1413c4e30a6b4f56 100644 --- a/pkg/progress/progressreader_test.go +++ b/pkg/progress/progressreader_test.go @@ -14,7 +14,7 @@ func TestOutputOnPrematureClose(t *testing.T) { pr := NewProgressReader(reader, ChanOutput(progressChan), int64(len(content)), "Test", "Read") - part := make([]byte, 4, 4) + part := make([]byte, 4) _, err := io.ReadFull(pr, part) if err != nil { pr.Close() diff --git a/pkg/registrar/registrar.go b/pkg/registrar/registrar.go index 803b0d3c9b91a4ace2cef765619b28212b88a391..df12db7eeb78d277386d459f05264f8f71007f9d 100644 --- a/pkg/registrar/registrar.go +++ b/pkg/registrar/registrar.go @@ -100,9 +100,7 @@ func (r *Registrar) GetNames(key string) ([]string, error) { } ls := make([]string, 0, len(names)) - for _, n := range names { - ls = append(ls, n) - } + ls = append(ls, names...) return ls, nil } diff --git a/pkg/urlutil/urlutil_test.go b/pkg/urlutil/urlutil_test.go index 75eb464fe5143a84650dd0fdad7a60542b682fd2..d84145a160f5b43c8ed967c33bb6336072ad7a03 100644 --- a/pkg/urlutil/urlutil_test.go +++ b/pkg/urlutil/urlutil_test.go @@ -29,13 +29,13 @@ var ( func TestValidGitTransport(t *testing.T) { for _, url := range gitUrls { - if IsGitTransport(url) == false { + if !IsGitTransport(url) { t.Fatalf("%q should be detected as valid Git prefix", url) } } for _, url := range incompleteGitUrls { - if IsGitTransport(url) == true { + if IsGitTransport(url) { t.Fatalf("%q should not be detected as valid Git prefix", url) } } @@ -43,19 +43,19 @@ func TestValidGitTransport(t *testing.T) { func TestIsGIT(t *testing.T) { for _, url := range gitUrls { - if IsGitURL(url) == false { + if !IsGitURL(url) { t.Fatalf("%q should be detected as valid Git url", url) } } for _, url := range incompleteGitUrls { - if IsGitURL(url) == false { + if !IsGitURL(url) { t.Fatalf("%q should be detected as valid Git url", url) } } for _, url := range invalidGitUrls { - if IsGitURL(url) == true { + if IsGitURL(url) { t.Fatalf("%q should not be detected as valid Git prefix", url) } } @@ -63,7 +63,7 @@ func TestIsGIT(t *testing.T) { func TestIsTransport(t *testing.T) { for _, url := range transportUrls { - if IsTransportURL(url) == false { + if !IsTransportURL(url) { t.Fatalf("%q should be detected as valid Transport url", url) } }