Selaa lähdekoodia

Merge pull request #36475 from IRCody/logdriver-errors

daemon/logger/ring.go: log error not instance
Yong Tang 7 vuotta sitten
vanhempi
commit
954e55b374
1 muutettua tiedostoa jossa 8 lisäystä ja 2 poistoa
  1. 8 2
      daemon/logger/ring.go

+ 8 - 2
daemon/logger/ring.go

@@ -93,7 +93,10 @@ func (r *RingLogger) Close() error {
 		}
 		}
 
 
 		if err := r.l.Log(msg); err != nil {
 		if err := r.l.Log(msg); err != nil {
-			logrus.WithField("driver", r.l.Name()).WithField("container", r.logInfo.ContainerID).Errorf("Error writing log message: %v", r.l)
+			logrus.WithField("driver", r.l.Name()).
+				WithField("container", r.logInfo.ContainerID).
+				WithError(err).
+				Errorf("Error writing log message")
 			logErr = true
 			logErr = true
 		}
 		}
 	}
 	}
@@ -114,7 +117,10 @@ func (r *RingLogger) run() {
 			return
 			return
 		}
 		}
 		if err := r.l.Log(msg); err != nil {
 		if err := r.l.Log(msg); err != nil {
-			logrus.WithField("driver", r.l.Name()).WithField("container", r.logInfo.ContainerID).Errorf("Error writing log message: %v", r.l)
+			logrus.WithField("driver", r.l.Name()).
+				WithField("container", r.logInfo.ContainerID).
+				WithError(err).
+				Errorf("Error writing log message")
 		}
 		}
 	}
 	}
 }
 }