瀏覽代碼

graphdriver/aufs: SA4021: x = append(y) is equivalent to x = y (staticcheck)

```
daemon/graphdriver/aufs/aufs_test.go:746:8: SA4021: x = append(y) is equivalent to x = y (staticcheck)
	ids = append(ids[2:])
	      ^
```

Also pre-allocating the ids slice while we're at it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 5 年之前
父節點
當前提交
94647b5d86
共有 1 個文件被更改,包括 3 次插入3 次删除
  1. 3 3
      daemon/graphdriver/aufs/aufs_test.go

+ 3 - 3
daemon/graphdriver/aufs/aufs_test.go

@@ -729,9 +729,9 @@ func BenchmarkConcurrentAccess(b *testing.B) {
 
 
 	numConcurrent := 256
 	numConcurrent := 256
 	// create a bunch of ids
 	// create a bunch of ids
-	var ids []string
+	ids := make([]string, numConcurrent)
 	for i := 0; i < numConcurrent; i++ {
 	for i := 0; i < numConcurrent; i++ {
-		ids = append(ids, stringid.GenerateRandomID())
+		ids[i] = stringid.GenerateRandomID()
 	}
 	}
 
 
 	if err := d.Create(ids[0], "", nil); err != nil {
 	if err := d.Create(ids[0], "", nil); err != nil {
@@ -743,7 +743,7 @@ func BenchmarkConcurrentAccess(b *testing.B) {
 	}
 	}
 
 
 	parent := ids[1]
 	parent := ids[1]
-	ids = append(ids[2:])
+	ids = ids[2:]
 
 
 	chErr := make(chan error, numConcurrent)
 	chErr := make(chan error, numConcurrent)
 	var outerGroup sync.WaitGroup
 	var outerGroup sync.WaitGroup