Merge pull request #36095 from yongtang/36083-network-inspect-created-time
Fix issue where network inspect does not show Created time for networks in swarm scope
This commit is contained in:
commit
924fb0e843
2 changed files with 35 additions and 0 deletions
|
@ -168,6 +168,7 @@ func BasicNetworkFromGRPC(n swarmapi.Network) basictypes.NetworkResource {
|
|||
Ingress: IsIngressNetwork(&n),
|
||||
Labels: n.Spec.Annotations.Labels,
|
||||
}
|
||||
nr.Created, _ = gogotypes.TimestampFromProto(n.Meta.CreatedAt)
|
||||
|
||||
if n.Spec.GetNetwork() != "" {
|
||||
nr.ConfigFrom = networktypes.ConfigReference{
|
||||
|
|
34
daemon/cluster/convert/network_test.go
Normal file
34
daemon/cluster/convert/network_test.go
Normal file
|
@ -0,0 +1,34 @@
|
|||
package convert
|
||||
|
||||
import (
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
swarmapi "github.com/docker/swarmkit/api"
|
||||
gogotypes "github.com/gogo/protobuf/types"
|
||||
)
|
||||
|
||||
func TestNetworkConvertBasicNetworkFromGRPCCreatedAt(t *testing.T) {
|
||||
expected, err := time.Parse("Jan 2, 2006 at 3:04pm (MST)", "Jan 10, 2018 at 7:54pm (PST)")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
createdAt, err := gogotypes.TimestampProto(expected)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
nw := swarmapi.Network{
|
||||
Meta: swarmapi.Meta{
|
||||
Version: swarmapi.Version{
|
||||
Index: 1,
|
||||
},
|
||||
CreatedAt: createdAt,
|
||||
},
|
||||
}
|
||||
|
||||
n := BasicNetworkFromGRPC(nw)
|
||||
if !n.Created.Equal(expected) {
|
||||
t.Fatalf("expected time %s; received %s", expected, n.Created)
|
||||
}
|
||||
}
|
Loading…
Add table
Reference in a new issue