瀏覽代碼

Merge pull request #40867 from BurtonQin/double-lock

plugin: Add No-Lock version of resolvePluginID to fix double Rlock
Sebastiaan van Stijn 5 年之前
父節點
當前提交
8e2e2bdb9b
共有 1 個文件被更改,包括 1 次插入3 次删除
  1. 1 3
      plugin/store.go

+ 1 - 3
plugin/store.go

@@ -249,10 +249,8 @@ func (ps *Store) CallHandler(p *v2.Plugin) {
 	}
 }
 
+// resolvePluginID must be protected by ps.RLock
 func (ps *Store) resolvePluginID(idOrName string) (string, error) {
-	ps.RLock() // todo: fix
-	defer ps.RUnlock()
-
 	if validFullID.MatchString(idOrName) {
 		return idOrName, nil
 	}