diff --git a/api/types/versions/v1p19/types.go b/api/types/versions/v1p19/types.go index 0260486608..a2d5337116 100644 --- a/api/types/versions/v1p19/types.go +++ b/api/types/versions/v1p19/types.go @@ -24,5 +24,5 @@ type ContainerConfig struct { Memory int64 MemorySwap int64 CPUShares int64 `json:"CpuShares"` - CPUSet string `json:"CpuSet"` + CPUSet string `json:"Cpuset"` } diff --git a/api/types/versions/v1p20/types.go b/api/types/versions/v1p20/types.go index dc6b4e55cd..6673f76de8 100644 --- a/api/types/versions/v1p20/types.go +++ b/api/types/versions/v1p20/types.go @@ -16,7 +16,8 @@ type ContainerJSON struct { // ContainerConfig is a backcompatibility struct used in ContainerJSON for the API 1.20 type ContainerConfig struct { *runconfig.Config - // backward compatibility, it lives now in HostConfig + + // backward compatibility, they now live in HostConfig VolumeDriver string } diff --git a/integration-cli/docker_api_inspect_unix_test.go b/integration-cli/docker_api_inspect_unix_test.go new file mode 100644 index 0000000000..3120eb67c2 --- /dev/null +++ b/integration-cli/docker_api_inspect_unix_test.go @@ -0,0 +1,38 @@ +// +build !windows + +package main + +import ( + "encoding/json" + "fmt" + "net/http" + + "github.com/go-check/check" +) + +// #16665 +func (s *DockerSuite) TestInspectApiCpusetInConfigPre120(c *check.C) { + testRequires(c, DaemonIsLinux) + testRequires(c, cgroupCpuset) + + name := "cpusetinconfig-pre120" + dockerCmd(c, "run", "--name", name, "--cpuset", "0-1", "busybox", "true") + + status, body, err := sockRequest("GET", fmt.Sprintf("/v1.19/containers/%s/json", name), nil) + c.Assert(status, check.Equals, http.StatusOK) + c.Assert(err, check.IsNil) + + var inspectJSON map[string]interface{} + if err = json.Unmarshal(body, &inspectJSON); err != nil { + c.Fatalf("unable to unmarshal body for version 1.19: %v", err) + } + + config, ok := inspectJSON["Config"] + if !ok { + c.Fatal("Unable to find 'Config'") + } + cfg := config.(map[string]interface{}) + if _, ok := cfg["Cpuset"]; !ok { + c.Fatal("Api version 1.19 expected to include Cpuset in 'Config'") + } +} diff --git a/integration-cli/docker_cli_kill_test.go b/integration-cli/docker_cli_kill_test.go index 1d34f5721a..5632db71e8 100644 --- a/integration-cli/docker_cli_kill_test.go +++ b/integration-cli/docker_cli_kill_test.go @@ -95,7 +95,7 @@ func (s *DockerSuite) TestKillWithInvalidSignal(c *check.C) { } } -func (s *DockerSuite) TestKillofStoppedContainerAPIPre120(c *check.C) { +func (s *DockerSuite) TestKillStoppedContainerAPIPre120(c *check.C) { testRequires(c, DaemonIsLinux) dockerCmd(c, "run", "--name", "docker-kill-test-api", "-d", "busybox", "top") dockerCmd(c, "stop", "docker-kill-test-api")