浏览代码

allocateNetwork: don't assign unneeded variables

allocateNetwork() can return early, in which case these variables were unused.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 5 年之前
父节点
当前提交
84ef60cba2
共有 1 个文件被更改,包括 5 次插入3 次删除
  1. 5 3
      daemon/container_operations.go

+ 5 - 3
daemon/container_operations.go

@@ -527,13 +527,15 @@ func (daemon *Daemon) updateContainerNetworkSettings(container *container.Contai
 }
 
 func (daemon *Daemon) allocateNetwork(container *container.Container) (retErr error) {
-	start := time.Now()
-	controller := daemon.netController
-
 	if daemon.netController == nil {
 		return nil
 	}
 
+	var (
+		start      = time.Now()
+		controller = daemon.netController
+	)
+
 	// Cleanup any stale sandbox left over due to ungraceful daemon shutdown
 	if err := controller.SandboxDestroy(container.ID); err != nil {
 		logrus.Errorf("failed to cleanup up stale network sandbox for container %s", container.ID)