Преглед изворни кода

Merge pull request #11054 from MabinGo/checkfileoper1

Add the file close operation before function return to advoid resource leaking
Jessie Frazelle пре 10 година
родитељ
комит
82aa950f4e
1 измењених фајлова са 2 додато и 1 уклоњено
  1. 2 1
      daemon/graphdriver/devmapper/mount.go

+ 2 - 1
daemon/graphdriver/devmapper/mount.go

@@ -55,13 +55,14 @@ func ProbeFsType(device string) (string, error) {
 	if err != nil {
 	if err != nil {
 		return "", err
 		return "", err
 	}
 	}
+	defer file.Close()
 
 
 	buffer := make([]byte, maxLen)
 	buffer := make([]byte, maxLen)
 	l, err := file.Read(buffer)
 	l, err := file.Read(buffer)
 	if err != nil {
 	if err != nil {
 		return "", err
 		return "", err
 	}
 	}
-	file.Close()
+
 	if uint64(l) != maxLen {
 	if uint64(l) != maxLen {
 		return "", fmt.Errorf("unable to detect filesystem type of %s, short read", device)
 		return "", fmt.Errorf("unable to detect filesystem type of %s, short read", device)
 	}
 	}