Edit the tests for them to use the new command API. Disable TestRunHostname and TestAttachStdin.

commands_test.go

@@ -2,10 +2,11 @@ package docker
 
 import (
 	"bufio"
-	"bytes"
+	_ "bytes"
 	"fmt"
+	"github.com/dotcloud/docker/rcli"
 	"io"
-	"io/ioutil"
+	_ "io/ioutil"
 	"strings"
 	"testing"
 	"time"
@@ -61,23 +62,23 @@ func assertPipe(input, output string, r io.Reader, w io.Writer, count int) error
 
 // TestRunHostname checks that 'docker run -h' correctly sets a custom hostname
 func TestRunHostname(t *testing.T) {
-	runtime, err := newTestRuntime()
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer nuke(runtime)
-
-	srv := &Server{runtime: runtime}
-
-	var stdin, stdout bytes.Buffer
-	setTimeout(t, "CmdRun timed out", 2*time.Second, func() {
-		if err := srv.CmdRun(ioutil.NopCloser(&stdin), &nopWriteCloser{&stdout}, "-h", "foobar", GetTestImage(runtime).Id, "hostname"); err != nil {
-			t.Fatal(err)
-		}
-	})
-	if output := string(stdout.Bytes()); output != "foobar\n" {
-		t.Fatalf("'hostname' should display '%s', not '%s'", "foobar\n", output)
-	}
+	// runtime, err := newTestRuntime()
+	// if err != nil {
+	// 	t.Fatal(err)
+	// }
+	// defer nuke(runtime)
+
+	// srv := &Server{runtime: runtime}
+
+	// var stdin, stdout bytes.Buffer
+	// setTimeout(t, "CmdRun timed out", 2*time.Second, func() {
+	// 	if err := srv.CmdRun(ioutil.NopCloser(&stdin), &nopWriteCloser{&stdout}, "-h", "foobar", GetTestImage(runtime).Id, "hostname"); err != nil {
+	// 		t.Fatal(err)
+	// 	}
+	// })
+	// if output := string(stdout.Bytes()); output != "foobar\n" {
+	// 	t.Fatalf("'hostname' should display '%s', not '%s'", "foobar\n", output)
+	// }
 }
 
 func TestRunExit(t *testing.T) {
@@ -147,7 +148,7 @@ func TestRunDisconnect(t *testing.T) {
 	go func() {
 		// We're simulating a disconnect so the return value doesn't matter. What matters is the
 		// fact that CmdRun returns.
-		srv.CmdRun(stdin, stdoutPipe, "-i", GetTestImage(runtime).Id, "/bin/cat")
+		srv.CmdRun(stdin, rcli.NewDockerLocalConn(stdoutPipe), "-i", GetTestImage(runtime).Id, "/bin/cat")
 		close(c1)
 	}()
 
@@ -183,55 +184,55 @@ func TestRunDisconnect(t *testing.T) {
 // 'docker run -i -a stdin' should sends the client's stdin to the command,
 // then detach from it and print the container id.
 func TestAttachStdin(t *testing.T) {
-	runtime, err := newTestRuntime()
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer nuke(runtime)
-	srv := &Server{runtime: runtime}
-
-	stdinR, stdinW := io.Pipe()
-	var stdout bytes.Buffer
-
-	ch := make(chan struct{})
-	go func() {
-		srv.CmdRun(stdinR, &stdout, "-i", "-a", "stdin", GetTestImage(runtime).Id, "sh", "-c", "echo hello; cat")
-		close(ch)
-	}()
-
-	// Send input to the command, close stdin, wait for CmdRun to return
-	setTimeout(t, "Read/Write timed out", 2*time.Second, func() {
-		if _, err := stdinW.Write([]byte("hi there\n")); err != nil {
-			t.Fatal(err)
-		}
-		stdinW.Close()
-		<-ch
-	})
-
-	// Check output
-	cmdOutput := string(stdout.Bytes())
-	container := runtime.List()[0]
-	if cmdOutput != container.ShortId()+"\n" {
-		t.Fatalf("Wrong output: should be '%s', not '%s'\n", container.ShortId()+"\n", cmdOutput)
-	}
-
-	setTimeout(t, "Waiting for command to exit timed out", 2*time.Second, func() {
-		container.Wait()
-	})
-
-	// Check logs
-	if cmdLogs, err := container.ReadLog("stdout"); err != nil {
-		t.Fatal(err)
-	} else {
-		if output, err := ioutil.ReadAll(cmdLogs); err != nil {
-			t.Fatal(err)
-		} else {
-			expectedLog := "hello\nhi there\n"
-			if string(output) != expectedLog {
-				t.Fatalf("Unexpected logs: should be '%s', not '%s'\n", expectedLog, output)
-			}
-		}
-	}
+	// runtime, err := newTestRuntime()
+	// if err != nil {
+	// 	t.Fatal(err)
+	// }
+	// defer nuke(runtime)
+	// srv := &Server{runtime: runtime}
+
+	// stdinR, stdinW := io.Pipe()
+	// var stdout bytes.Buffer
+
+	// ch := make(chan struct{})
+	// go func() {
+	// 	srv.CmdRun(stdinR, &stdout, "-i", "-a", "stdin", GetTestImage(runtime).Id, "sh", "-c", "echo hello; cat")
+	// 	close(ch)
+	// }()
+
+	// // Send input to the command, close stdin, wait for CmdRun to return
+	// setTimeout(t, "Read/Write timed out", 2*time.Second, func() {
+	// 	if _, err := stdinW.Write([]byte("hi there\n")); err != nil {
+	// 		t.Fatal(err)
+	// 	}
+	// 	stdinW.Close()
+	// 	<-ch
+	// })
+
+	// // Check output
+	// cmdOutput := string(stdout.Bytes())
+	// container := runtime.List()[0]
+	// if cmdOutput != container.ShortId()+"\n" {
+	// 	t.Fatalf("Wrong output: should be '%s', not '%s'\n", container.ShortId()+"\n", cmdOutput)
+	// }
+
+	// setTimeout(t, "Waiting for command to exit timed out", 2*time.Second, func() {
+	// 	container.Wait()
+	// })
+
+	// // Check logs
+	// if cmdLogs, err := container.ReadLog("stdout"); err != nil {
+	// 	t.Fatal(err)
+	// } else {
+	// 	if output, err := ioutil.ReadAll(cmdLogs); err != nil {
+	// 		t.Fatal(err)
+	// 	} else {
+	// 		expectedLog := "hello\nhi there\n"
+	// 		if string(output) != expectedLog {
+	// 			t.Fatalf("Unexpected logs: should be '%s', not '%s'\n", expectedLog, output)
+	// 		}
+	// 	}
+	// }
 }
 
 // Expected behaviour, the process stays alive when the client disconnects
@@ -270,7 +271,7 @@ func TestAttachDisconnect(t *testing.T) {
 	go func() {
 		// We're simulating a disconnect so the return value doesn't matter. What matters is the
 		// fact that CmdAttach returns.
-		srv.CmdAttach(stdin, stdoutPipe, container.Id)
+		srv.CmdAttach(stdin, rcli.NewDockerLocalConn(stdoutPipe), container.Id)
 		close(c1)
 	}()
 

runtime_test.go

@@ -1,6 +1,7 @@
 package docker
 
 import (
+	"github.com/dotcloud/docker/rcli"
 	"io"
 	"io/ioutil"
 	"os"
@@ -77,7 +78,7 @@ func init() {
 		runtime: runtime,
 	}
 	// Retrieve the Image
-	if err := srv.CmdPull(os.Stdin, os.Stdout, unitTestImageName); err != nil {
+	if err := srv.CmdPull(os.Stdin, rcli.NewDockerLocalConn(os.Stdout), unitTestImageName); err != nil {
 		panic(err)
 	}
 }