Merge pull request #39959 from thaJeztah/fix_golint

integration-cli: fix golint issues

integration-cli/checker/checker.go

@@ -9,32 +9,38 @@ import (
 	"gotest.tools/assert/cmp"
 )
 
+// Compare defines the interface to compare values
 type Compare func(x interface{}) assert.BoolOrComparison
 
+// False checks if the value is false
 func False() Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return !x.(bool)
 	}
 }
 
+// True checks if the value is true
 func True() Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return x
 	}
 }
 
+// Equals checks if the value is equal to the given value
 func Equals(y interface{}) Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return cmp.Equal(x, y)
 	}
 }
 
+// Contains checks if the value contains the given value
 func Contains(y interface{}) Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return cmp.Contains(x, y)
 	}
 }
 
+// Not checks if two values are not
 func Not(c Compare) Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		r := c(x)
@@ -49,30 +55,30 @@ func Not(c Compare) Compare {
 	}
 }
 
+// DeepEquals checks if two values are equal
 func DeepEquals(y interface{}) Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return cmp.DeepEqual(x, y)
 	}
 }
 
+// DeepEquals compares if two values are deepequal
 func HasLen(y int) Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return cmp.Len(x, y)
 	}
 }
 
+// DeepEquals checks if the given value is nil
 func IsNil() Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return cmp.Nil(x)
 	}
 }
 
+// GreaterThan checks if the value is greater than the given value
 func GreaterThan(y int) Compare {
 	return func(x interface{}) assert.BoolOrComparison {
 		return x.(int) > y
 	}
 }
-
-func NotNil() Compare {
-	return Not(IsNil())
-}