Ver código fonte

remove Register return value
Since Register() will never return err,remove the return value

Signed-off-by: NickrenREN <yuquan.ren@easystack.cn>

NickrenREN 8 anos atrás
pai
commit
78b50c129e
3 arquivos alterados com 3 adições e 11 exclusões
  1. 1 3
      daemon/container.go
  2. 1 3
      daemon/create.go
  3. 1 5
      daemon/daemon.go

+ 1 - 3
daemon/container.go

@@ -88,7 +88,7 @@ func (daemon *Daemon) load(id string) (*container.Container, error) {
 }
 }
 
 
 // Register makes a container object usable by the daemon as <container.ID>
 // Register makes a container object usable by the daemon as <container.ID>
-func (daemon *Daemon) Register(c *container.Container) error {
+func (daemon *Daemon) Register(c *container.Container) {
 	// Attach to stdout and stderr
 	// Attach to stdout and stderr
 	if c.Config.OpenStdin {
 	if c.Config.OpenStdin {
 		c.StreamConfig.NewInputPipes()
 		c.StreamConfig.NewInputPipes()
@@ -98,8 +98,6 @@ func (daemon *Daemon) Register(c *container.Container) error {
 
 
 	daemon.containers.Add(c.ID, c)
 	daemon.containers.Add(c.ID, c)
 	daemon.idIndex.Add(c.ID)
 	daemon.idIndex.Add(c.ID)
-
-	return nil
 }
 }
 
 
 func (daemon *Daemon) newContainer(name string, config *containertypes.Config, hostConfig *containertypes.HostConfig, imgID image.ID, managed bool) (*container.Container, error) {
 func (daemon *Daemon) newContainer(name string, config *containertypes.Config, hostConfig *containertypes.HostConfig, imgID image.ID, managed bool) (*container.Container, error) {

+ 1 - 3
daemon/create.go

@@ -151,9 +151,7 @@ func (daemon *Daemon) create(params types.ContainerCreateConfig, managed bool) (
 		logrus.Errorf("Error saving new container to disk: %v", err)
 		logrus.Errorf("Error saving new container to disk: %v", err)
 		return nil, err
 		return nil, err
 	}
 	}
-	if err := daemon.Register(container); err != nil {
-		return nil, err
-	}
+	daemon.Register(container)
 	daemon.LogContainerEvent(container, "create")
 	daemon.LogContainerEvent(container, "create")
 	return container, nil
 	return container, nil
 }
 }

+ 1 - 5
daemon/daemon.go

@@ -168,11 +168,7 @@ func (daemon *Daemon) restore() error {
 			delete(containers, id)
 			delete(containers, id)
 			continue
 			continue
 		}
 		}
-		if err := daemon.Register(c); err != nil {
-			logrus.Errorf("Failed to register container %s: %s", c.ID, err)
-			delete(containers, id)
-			continue
-		}
+		daemon.Register(c)
 
 
 		// verify that all volumes valid and have been migrated from the pre-1.7 layout
 		// verify that all volumes valid and have been migrated from the pre-1.7 layout
 		if err := daemon.verifyVolumesInfo(c); err != nil {
 		if err := daemon.verifyVolumesInfo(c); err != nil {