Browse Source

Merge pull request #3787 from pwaller/issue-3786

Fix for issue #3786 `docker rm` unmounts in the wrong order
Guillaume J. Charmes 11 years ago
parent
commit
77d4df1e0b
1 changed files with 3 additions and 3 deletions
  1. 3 3
      container.go

+ 3 - 3
container.go

@@ -1365,9 +1365,9 @@ func (container *Container) Unmount() error {
 		mounts = append(mounts, path.Join(root, r))
 	}
 
-	for _, m := range mounts {
-		if lastError := mount.Unmount(m); lastError != nil {
-			err = lastError
+	for i := len(mounts) - 1; i >= 0; i-- {
+		if lastError := mount.Unmount(mounts[i]); lastError != nil {
+			err = fmt.Errorf("Failed to umount %v: %v", mounts[i], lastError)
 		}
 	}
 	if err != nil {