diff --git a/builder/remotecontext/urlutil/urlutil.go b/builder/remotecontext/urlutil/urlutil.go index e38988a30c..e8459cc820 100644 --- a/builder/remotecontext/urlutil/urlutil.go +++ b/builder/remotecontext/urlutil/urlutil.go @@ -12,7 +12,7 @@ import ( // urlPathWithFragmentSuffix matches fragments to use as Git reference and build // context from the Git repository. See IsGitURL for details. -var urlPathWithFragmentSuffix = regexp.MustCompile(".git(?:#.+)?$") +var urlPathWithFragmentSuffix = regexp.MustCompile(`\.git(?:#.+)?$`) // IsURL returns true if the provided str is an HTTP(S) URL by checking if it // has a http:// or https:// scheme. No validation is performed to verify if the diff --git a/builder/remotecontext/urlutil/urlutil_test.go b/builder/remotecontext/urlutil/urlutil_test.go index 6906118321..ed39f5f22e 100644 --- a/builder/remotecontext/urlutil/urlutil_test.go +++ b/builder/remotecontext/urlutil/urlutil_test.go @@ -17,6 +17,7 @@ var ( } invalidGitUrls = []string{ "http://github.com/docker/docker.git:#branch", + "https://github.com/docker/dgit", } )