Parcourir la source

Merge pull request #29908 from lixiaobing10051267/masterExpectedErr

optimize Fatalf with the expectedError
Akihiro Suda il y a 8 ans
Parent
commit
766e53d8cb
1 fichiers modifiés avec 3 ajouts et 2 suppressions
  1. 3 2
      pkg/httputils/resumablerequestreader_test.go

+ 3 - 2
pkg/httputils/resumablerequestreader_test.go

@@ -195,10 +195,11 @@ func TestResumableRequestReaderWithServerDoesntSupportByteRanges(t *testing.T) {
 	}
 	}
 	defer resreq.Close()
 	defer resreq.Close()
 
 
+	expectedError := "the server doesn't support byte ranges"
 	buf := make([]byte, 2)
 	buf := make([]byte, 2)
 	_, err = resreq.Read(buf)
 	_, err = resreq.Read(buf)
-	if err == nil || err.Error() != "the server doesn't support byte ranges" {
-		t.Fatalf("Expected an error 'the server doesn't support byte ranges', got %v", err)
+	if err == nil || err.Error() != expectedError {
+		t.Fatalf("Expected an error '%s', got %v", expectedError, err)
 	}
 	}
 }
 }