Return pointer from newBaseContainer
It makes code more consistent. Signed-off-by: Alexander Morozov <lk4d4@docker.com>
This commit is contained in:
parent
b6fa541877
commit
6d9bb99c97
3 changed files with 7 additions and 7 deletions
|
@ -177,10 +177,10 @@ func (daemon *Daemon) load(id string) (*Container, error) {
|
|||
}
|
||||
|
||||
if container.ID != id {
|
||||
return &container, fmt.Errorf("Container %s is stored at %s", container.ID, id)
|
||||
return container, fmt.Errorf("Container %s is stored at %s", container.ID, id)
|
||||
}
|
||||
|
||||
return &container, nil
|
||||
return container, nil
|
||||
}
|
||||
|
||||
// Register makes a container object usable by the daemon as <container.ID>
|
||||
|
@ -492,7 +492,7 @@ func (daemon *Daemon) newContainer(name string, config *runconfig.Config, imgID
|
|||
base.Driver = daemon.driver.String()
|
||||
base.ExecDriver = daemon.execDriver.Name()
|
||||
|
||||
return &base, err
|
||||
return base, err
|
||||
}
|
||||
|
||||
// GetFullContainerName returns a constructed container name. I think
|
||||
|
|
|
@ -599,8 +599,8 @@ func (daemon *Daemon) registerLinks(container *Container, hostConfig *runconfig.
|
|||
return nil
|
||||
}
|
||||
|
||||
func (daemon *Daemon) newBaseContainer(id string) Container {
|
||||
return Container{
|
||||
func (daemon *Daemon) newBaseContainer(id string) *Container {
|
||||
return &Container{
|
||||
CommonContainer: CommonContainer{
|
||||
ID: id,
|
||||
State: NewState(),
|
||||
|
|
|
@ -140,8 +140,8 @@ func (daemon *Daemon) registerLinks(container *Container, hostConfig *runconfig.
|
|||
return nil
|
||||
}
|
||||
|
||||
func (daemon *Daemon) newBaseContainer(id string) Container {
|
||||
return Container{
|
||||
func (daemon *Daemon) newBaseContainer(id string) *Container {
|
||||
return &Container{
|
||||
CommonContainer: CommonContainer{
|
||||
ID: id,
|
||||
State: NewState(),
|
||||
|
|
Loading…
Add table
Reference in a new issue