Explorar o código

Merge pull request #38909 from thaJeztah/fix_version_override

Fix client version not being pinned when set
Tibor Vass %!s(int64=6) %!d(string=hai) anos
pai
achega
6cce52c245
Modificáronse 1 ficheiros con 4 adicións e 2 borrados
  1. 4 2
      client/options.go

+ 4 - 2
client/options.go

@@ -45,8 +45,9 @@ func FromEnv(c *Client) error {
 	}
 	}
 
 
 	if version := os.Getenv("DOCKER_API_VERSION"); version != "" {
 	if version := os.Getenv("DOCKER_API_VERSION"); version != "" {
-		c.version = version
-		c.manualOverride = true
+		if err := WithVersion(version)(c); err != nil {
+			return err
+		}
 	}
 	}
 	return nil
 	return nil
 }
 }
@@ -139,6 +140,7 @@ func WithTLSClientConfig(cacertPath, certPath, keyPath string) func(*Client) err
 func WithVersion(version string) func(*Client) error {
 func WithVersion(version string) func(*Client) error {
 	return func(c *Client) error {
 	return func(c *Client) error {
 		c.version = version
 		c.version = version
+		c.manualOverride = true
 		return nil
 		return nil
 	}
 	}
 }
 }