From 673dd28e7e2fb6e40e4c56823900fdb152b9c53c Mon Sep 17 00:00:00 2001
From: Brian Goff <cpuguy83@gmail.com>
Date: Wed, 9 May 2018 21:14:54 -0400
Subject: [PATCH] Add metrics for log failures/partials

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
---
 daemon/logger/copier.go  |  4 ++++
 daemon/logger/metrics.go | 21 +++++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 daemon/logger/metrics.go

diff --git a/daemon/logger/copier.go b/daemon/logger/copier.go
index ae86777f33..e24272fa6d 100644
--- a/daemon/logger/copier.go
+++ b/daemon/logger/copier.go
@@ -81,6 +81,7 @@ func (c *Copier) copySrc(name string, src io.Reader) {
 				read, err := src.Read(buf[n:upto])
 				if err != nil {
 					if err != io.EOF {
+						logReadsFailedCount.Inc(1)
 						logrus.Errorf("Error scanning log stream: %s", err)
 						return
 					}
@@ -120,6 +121,7 @@ func (c *Copier) copySrc(name string, src io.Reader) {
 					}
 
 					if logErr := c.dst.Log(msg); logErr != nil {
+						logWritesFailedCount.Inc(1)
 						logrus.Errorf("Failed to log msg %q for logger %s: %s", msg.Line, c.dst.Name(), logErr)
 					}
 				}
@@ -143,6 +145,7 @@ func (c *Copier) copySrc(name string, src io.Reader) {
 						partialid = stringid.GenerateRandomID()
 						ordinal = 1
 						firstPartial = false
+						totalPartialLogs.Inc(1)
 					} else {
 						msg.Timestamp = partialTS
 					}
@@ -151,6 +154,7 @@ func (c *Copier) copySrc(name string, src io.Reader) {
 					hasMorePartial = true
 
 					if logErr := c.dst.Log(msg); logErr != nil {
+						logWritesFailedCount.Inc(1)
 						logrus.Errorf("Failed to log msg %q for logger %s: %s", msg.Line, c.dst.Name(), logErr)
 					}
 					p = 0
diff --git a/daemon/logger/metrics.go b/daemon/logger/metrics.go
new file mode 100644
index 0000000000..b7dfd38ec2
--- /dev/null
+++ b/daemon/logger/metrics.go
@@ -0,0 +1,21 @@
+package logger // import "github.com/docker/docker/daemon/logger"
+
+import (
+	"github.com/docker/go-metrics"
+)
+
+var (
+	logWritesFailedCount metrics.Counter
+	logReadsFailedCount  metrics.Counter
+	totalPartialLogs     metrics.Counter
+)
+
+func init() {
+	loggerMetrics := metrics.NewNamespace("logger", "", nil)
+
+	logWritesFailedCount = loggerMetrics.NewCounter("log_write_operations_failed", "Number of log write operations that failed")
+	logReadsFailedCount = loggerMetrics.NewCounter("log_read_operations_failed", "Number of log reads from container stdio that failed")
+	totalPartialLogs = loggerMetrics.NewCounter("log_entries_size_greater_than_buffer", "Number of log entries which are larger than the log buffer")
+
+	metrics.Register(loggerMetrics)
+}