Browse Source

more review changes

Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
Evan Hazlett 8 years ago
parent
commit
669a9dbe7f
1 changed files with 4 additions and 3 deletions
  1. 4 3
      api/server/router/swarm/cluster_routes.go

+ 4 - 3
api/server/router/swarm/cluster_routes.go

@@ -7,6 +7,7 @@ import (
 	"strconv"
 	"strconv"
 
 
 	"github.com/Sirupsen/logrus"
 	"github.com/Sirupsen/logrus"
+	"github.com/docker/docker/api/errors"
 	"github.com/docker/docker/api/server/httputils"
 	"github.com/docker/docker/api/server/httputils"
 	basictypes "github.com/docker/docker/api/types"
 	basictypes "github.com/docker/docker/api/types"
 	"github.com/docker/docker/api/types/filters"
 	"github.com/docker/docker/api/types/filters"
@@ -319,18 +320,18 @@ func (sr *swarmRouter) getSecret(ctx context.Context, w http.ResponseWriter, r *
 func (sr *swarmRouter) updateSecret(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
 func (sr *swarmRouter) updateSecret(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
 	var secret types.SecretSpec
 	var secret types.SecretSpec
 	if err := json.NewDecoder(r.Body).Decode(&secret); err != nil {
 	if err := json.NewDecoder(r.Body).Decode(&secret); err != nil {
-		return err
+		return errors.NewBadRequestError(err)
 	}
 	}
 
 
 	rawVersion := r.URL.Query().Get("version")
 	rawVersion := r.URL.Query().Get("version")
 	version, err := strconv.ParseUint(rawVersion, 10, 64)
 	version, err := strconv.ParseUint(rawVersion, 10, 64)
 	if err != nil {
 	if err != nil {
-		return fmt.Errorf("Invalid secret version '%s': %s", rawVersion, err.Error())
+		return errors.NewBadRequestError(fmt.Errorf("invalid secret version"))
 	}
 	}
 
 
 	id := vars["id"]
 	id := vars["id"]
 	if err := sr.backend.UpdateSecret(id, version, secret); err != nil {
 	if err := sr.backend.UpdateSecret(id, version, secret); err != nil {
-		return fmt.Errorf("Error updating secret: %s", err)
+		return errors.NewErrorWithStatusCode(err, http.StatusInternalServerError)
 	}
 	}
 
 
 	return nil
 	return nil