|
@@ -2858,26 +2858,28 @@ func (s *DockerSuite) TestRunUnshareProc(c *check.C) {
|
|
|
testRequires(c, Apparmor, DaemonIsLinux, NotUserNamespace)
|
|
|
|
|
|
name := "acidburn"
|
|
|
- out, _, err := dockerCmdWithError("run", "--name", name, "--security-opt", "seccomp:unconfined", "jess/unshare", "unshare", "-p", "-m", "-f", "-r", "--mount-proc=/proc", "mount")
|
|
|
+ out, _, err := dockerCmdWithError("run", "--name", name, "--security-opt", "seccomp:unconfined", "debian:jessie", "unshare", "-p", "-m", "-f", "-r", "--mount-proc=/proc", "mount")
|
|
|
if err == nil ||
|
|
|
!(strings.Contains(strings.ToLower(out), "permission denied") ||
|
|
|
strings.Contains(strings.ToLower(out), "operation not permitted")) {
|
|
|
- c.Fatalf("unshare with --mount-proc should have failed with permission denied, got: %s, %v", out, err)
|
|
|
+ c.Fatalf("unshare with --mount-proc should have failed with 'permission denied' or 'operation not permitted', got: %s, %v", out, err)
|
|
|
}
|
|
|
|
|
|
name = "cereal"
|
|
|
- out, _, err = dockerCmdWithError("run", "--name", name, "--security-opt", "seccomp:unconfined", "jess/unshare", "unshare", "-p", "-m", "-f", "-r", "mount", "-t", "proc", "none", "/proc")
|
|
|
+ out, _, err = dockerCmdWithError("run", "--name", name, "--security-opt", "seccomp:unconfined", "debian:jessie", "unshare", "-p", "-m", "-f", "-r", "mount", "-t", "proc", "none", "/proc")
|
|
|
if err == nil ||
|
|
|
- !(strings.Contains(strings.ToLower(out), "permission denied") ||
|
|
|
- strings.Contains(strings.ToLower(out), "operation not permitted")) {
|
|
|
- c.Fatalf("unshare and mount of /proc should have failed with permission denied, got: %s, %v", out, err)
|
|
|
+ !(strings.Contains(strings.ToLower(out), "mount: cannot mount none") ||
|
|
|
+ strings.Contains(strings.ToLower(out), "permission denied")) {
|
|
|
+ c.Fatalf("unshare and mount of /proc should have failed with 'mount: cannot mount none' or 'permission denied', got: %s, %v", out, err)
|
|
|
}
|
|
|
|
|
|
/* Ensure still fails if running privileged with the default policy */
|
|
|
name = "crashoverride"
|
|
|
- out, _, err = dockerCmdWithError("run", "--privileged", "--security-opt", "seccomp:unconfined", "--security-opt", "apparmor:docker-default", "--name", name, "jess/unshare", "unshare", "-p", "-m", "-f", "-r", "mount", "-t", "proc", "none", "/proc")
|
|
|
- if err == nil || !(strings.Contains(strings.ToLower(out), "permission denied") || strings.Contains(strings.ToLower(out), "operation not permitted")) {
|
|
|
- c.Fatalf("privileged unshare with apparmor should have failed with permission denied, got: %s, %v", out, err)
|
|
|
+ out, _, err = dockerCmdWithError("run", "--privileged", "--security-opt", "seccomp:unconfined", "--security-opt", "apparmor:docker-default", "--name", name, "debian:jessie", "unshare", "-p", "-m", "-f", "-r", "mount", "-t", "proc", "none", "/proc")
|
|
|
+ if err == nil ||
|
|
|
+ !(strings.Contains(strings.ToLower(out), "mount: cannot mount none") ||
|
|
|
+ strings.Contains(strings.ToLower(out), "permission denied")) {
|
|
|
+ c.Fatalf("privileged unshare with apparmor should have failed with 'mount: cannot mount none' or 'permission denied', got: %s, %v", out, err)
|
|
|
}
|
|
|
}
|
|
|
|