Forráskód Böngészése

Merge pull request #8179 from erikh/parser_fix_cmd_null

Parser fix cmd null
Tibor Vass 11 éve
szülő
commit
5ce7ee61ef
2 módosított fájl, 17 hozzáadás és 1 törlés
  1. 1 1
      builder/evaluator.go
  2. 16 0
      integration-cli/docker_cli_build_test.go

+ 1 - 1
builder/evaluator.go

@@ -150,7 +150,7 @@ func (b *Builder) Run(context io.Reader) (string, error) {
 	b.dockerfile = ast
 
 	// some initializations that would not have been supplied by the caller.
-	b.Config = &runconfig.Config{Entrypoint: []string{}, Cmd: []string{"/bin/sh", "-c"}}
+	b.Config = &runconfig.Config{Entrypoint: []string{}, Cmd: nil}
 	b.TmpContainers = map[string]struct{}{}
 
 	for i, n := range b.dockerfile.Children {

+ 16 - 0
integration-cli/docker_cli_build_test.go

@@ -2126,3 +2126,19 @@ func TestBuildClearCmd(t *testing.T) {
 	}
 	logDone("build - clearcmd")
 }
+
+func TestBuildEmptyCmd(t *testing.T) {
+	name := "testbuildemptycmd"
+	defer deleteImages(name)
+	if _, err := buildImage(name, "FROM scratch\nMAINTAINER quux\n", true); err != nil {
+		t.Fatal(err)
+	}
+	res, err := inspectFieldJSON(name, "Config.Cmd")
+	if err != nil {
+		t.Fatal(err)
+	}
+	if res != "null" {
+		t.Fatalf("Cmd %s, expected %s", res, "null")
+	}
+	logDone("build - empty cmd")
+}