Explorar el Código

client: Client.Ping: re-use request when falling back to GET

Re-use the request, and change the method to GET instead of building
a new request "from scratch".

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn hace 1 año
padre
commit
58dc0fcd1e
Se han modificado 1 ficheros con 3 adiciones y 5 borrados
  1. 3 5
      client/ping.go

+ 3 - 5
client/ping.go

@@ -37,11 +37,9 @@ func (cli *Client) Ping(ctx context.Context) (types.Ping, error) {
 		return ping, err
 	}
 
-	req, err = cli.buildRequest(http.MethodGet, path.Join(cli.basePath, "/_ping"), nil, nil)
-	if err != nil {
-		return ping, err
-	}
-	serverResp, err = cli.doRequest(ctx, req)
+	// HEAD failed; fallback to GET.
+	req.Method = http.MethodGet
+	serverResp, err = cli.doRequest(req)
 	defer ensureReaderClosed(serverResp)
 	if err != nil {
 		return ping, err