浏览代码

Merge pull request #26834 from thaJeztah/deprecate-docker-daemon

Deprecate "daemon" subcommand
Phil Estes 8 年之前
父节点
当前提交
57f0164fd2
共有 3 个文件被更改,包括 10 次插入8 次删除
  1. 1 0
      cmd/docker/daemon_unix.go
  2. 7 0
      docs/deprecated.md
  3. 2 8
      integration-cli/docker_cli_help_test.go

+ 1 - 0
cmd/docker/daemon_unix.go

@@ -24,6 +24,7 @@ func newDaemonCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return runDaemon()
 			return runDaemon()
 		},
 		},
+		Deprecated: "and will be removed in Docker 1.16. Please run `dockerd` directly.",
 	}
 	}
 	cmd.SetHelpFunc(helpFunc)
 	cmd.SetHelpFunc(helpFunc)
 	return cmd
 	return cmd

+ 7 - 0
docs/deprecated.md

@@ -17,6 +17,13 @@ To learn more about Docker Engine's deprecation policy,
 see [Feature Deprecation Policy](index.md#feature-deprecation-policy).
 see [Feature Deprecation Policy](index.md#feature-deprecation-policy).
 
 
 
 
+### `docker daemon` subcommand
+**Deprecated In Release: [v1.13](https://github.com/docker/docker/releases/)**
+
+**Target For Removal In Release: v1.16**
+
+The daemon is moved to a separate binary (`dockerd`), and should be used instead.
+
 ### Three argument form in `docker import`
 ### Three argument form in `docker import`
 **Deprecated In Release: [v0.6.7](https://github.com/docker/docker/releases/tag/v0.6.7)**
 **Deprecated In Release: [v0.6.7](https://github.com/docker/docker/releases/tag/v0.6.7)**
 
 

+ 2 - 8
integration-cli/docker_cli_help_test.go

@@ -86,14 +86,8 @@ func (s *DockerSuite) TestHelpTextVerify(c *check.C) {
 		cmds := []string{}
 		cmds := []string{}
 		// Grab all chars starting at "Commands:"
 		// Grab all chars starting at "Commands:"
 		helpOut := strings.Split(out[i:], "\n")
 		helpOut := strings.Split(out[i:], "\n")
-		// First line is just "Commands:"
-		if isLocalDaemon {
-			// Replace first line with "daemon" command since it's not part of the list of commands.
-			helpOut[0] = " daemon"
-		} else {
-			// Skip first line
-			helpOut = helpOut[1:]
-		}
+		// Skip first line, it is just "Commands:"
+		helpOut = helpOut[1:]
 
 
 		// Create the list of commands we want to test
 		// Create the list of commands we want to test
 		cmdsToTest := []string{}
 		cmdsToTest := []string{}