瀏覽代碼

builder/dockerfile: improve error message about build stage name

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Akihiro Suda 8 年之前
父節點
當前提交
50a9be4bf5
共有 2 個文件被更改,包括 1 次插入2 次删除
  1. 1 1
      builder/dockerfile/dispatchers.go
  2. 0 1
      builder/dockerfile/dispatchers_test.go

+ 1 - 1
builder/dockerfile/dispatchers.go

@@ -211,7 +211,7 @@ func from(b *Builder, args []string, attributes map[string]bool, original string
 			return errors.Errorf("invalid name for build stage: %q, name can't start with a number or contain symbols", ctxName)
 		}
 	} else if len(args) != 1 {
-		return errExactlyOneArgument("FROM")
+		return errors.New("FROM requires either one or three arguments")
 	}
 
 	if err := b.flags.Parse(); err != nil {

+ 0 - 1
builder/dockerfile/dispatchers_test.go

@@ -20,7 +20,6 @@ type commandWithFunction struct {
 func TestCommandsExactlyOneArgument(t *testing.T) {
 	commands := []commandWithFunction{
 		{"MAINTAINER", func(args []string) error { return maintainer(nil, args, nil, "") }},
-		{"FROM", func(args []string) error { return from(nil, args, nil, "") }},
 		{"WORKDIR", func(args []string) error { return workdir(nil, args, nil, "") }},
 		{"USER", func(args []string) error { return user(nil, args, nil, "") }},
 		{"STOPSIGNAL", func(args []string) error { return stopSignal(nil, args, nil, "") }}}