Ver Fonte

api/server/router/grpc: fix some nits in NewRouter()

These were changes I drafted when reviewing 7c731e02a980666e262c68d4995f5643b6ffae30,
and had these stashed in my local git;

- rename receiver to prevent "unconsistent receiver name" warnings
- make NewRouter() slightly more idiomatic, and wrap the options,
  to make them easier to read.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 758714ed6dab4d865bde55b3f670478605892099)
Signed-off-by: Ameya Gawde <agawde@mirantis.com>
Sebastiaan van Stijn há 3 anos atrás
pai
commit
50a03fdc6a
1 ficheiros alterados com 10 adições e 10 exclusões
  1. 10 10
      api/server/router/grpc/grpc.go

+ 10 - 10
api/server/router/grpc/grpc.go

@@ -15,12 +15,12 @@ type grpcRouter struct {
 
 
 // NewRouter initializes a new grpc http router
 // NewRouter initializes a new grpc http router
 func NewRouter(backends ...Backend) router.Router {
 func NewRouter(backends ...Backend) router.Router {
-	opts := []grpc.ServerOption{grpc.UnaryInterceptor(grpcerrors.UnaryServerInterceptor), grpc.StreamInterceptor(grpcerrors.StreamServerInterceptor)}
-	server := grpc.NewServer(opts...)
-
 	r := &grpcRouter{
 	r := &grpcRouter{
-		h2Server:   &http2.Server{},
-		grpcServer: server,
+		h2Server: &http2.Server{},
+		grpcServer: grpc.NewServer(
+			grpc.UnaryInterceptor(grpcerrors.UnaryServerInterceptor),
+			grpc.StreamInterceptor(grpcerrors.StreamServerInterceptor),
+		),
 	}
 	}
 	for _, b := range backends {
 	for _, b := range backends {
 		b.RegisterGRPC(r.grpcServer)
 		b.RegisterGRPC(r.grpcServer)
@@ -30,12 +30,12 @@ func NewRouter(backends ...Backend) router.Router {
 }
 }
 
 
 // Routes returns the available routers to the session controller
 // Routes returns the available routers to the session controller
-func (r *grpcRouter) Routes() []router.Route {
-	return r.routes
+func (gr *grpcRouter) Routes() []router.Route {
+	return gr.routes
 }
 }
 
 
-func (r *grpcRouter) initRoutes() {
-	r.routes = []router.Route{
-		router.NewPostRoute("/grpc", r.serveGRPC),
+func (gr *grpcRouter) initRoutes() {
+	gr.routes = []router.Route{
+		router.NewPostRoute("/grpc", gr.serveGRPC),
 	}
 	}
 }
 }