Pārlūkot izejas kodu

Merge pull request #4312 from shykes/engine-error-reporting

Engine: clearer job error reporting
Victor Vieux 11 gadi atpakaļ
vecāks
revīzija
4a4915c8ee
1 mainītis faili ar 5 papildinājumiem un 2 dzēšanām
  1. 5 2
      engine/job.go

+ 5 - 2
engine/job.go

@@ -74,7 +74,7 @@ func (job *Job) Run() error {
 		return err
 	}
 	if job.status != 0 {
-		return fmt.Errorf("%s: %s", job.Name, errorMessage)
+		return fmt.Errorf("%s", errorMessage)
 	}
 	return nil
 }
@@ -201,11 +201,14 @@ func (job *Job) Printf(format string, args ...interface{}) (n int, err error) {
 }
 
 func (job *Job) Errorf(format string, args ...interface{}) Status {
+	if format[len(format)-1] != '\n' {
+		format = format + "\n"
+	}
 	fmt.Fprintf(job.Stderr, format, args...)
 	return StatusErr
 }
 
 func (job *Job) Error(err error) Status {
-	fmt.Fprintf(job.Stderr, "%s", err)
+	fmt.Fprintf(job.Stderr, "%s\n", err)
 	return StatusErr
 }