Kaynağa Gözat

Add checking trailing space for all lines of the help output

Signed-off-by: Zen Lin(Zhinan Lin) <linzhinan@huawei.com>
Zen Lin(Zhinan Lin) 10 yıl önce
ebeveyn
işleme
491b63e0da
1 değiştirilmiş dosya ile 7 ekleme ve 1 silme
  1. 7 1
      integration-cli/docker_cli_help_test.go

+ 7 - 1
integration-cli/docker_cli_help_test.go

@@ -59,6 +59,11 @@ func TestHelpTextVerify(t *testing.T) {
 				t.Fatalf("Line is too long(%d chars):\n%s", len(line), line)
 			}
 
+			// All lines should not end with a space
+			if strings.HasSuffix(line, " ") {
+				t.Fatalf("Line should not end with a space: %s", line)
+			}
+
 			if scanForHome && strings.Contains(line, `=`+home) {
 				t.Fatalf("Line should use '%q' instead of %q:\n%s", homedir.GetShortcutString(), home, line)
 			}
@@ -131,10 +136,11 @@ func TestHelpTextVerify(t *testing.T) {
 					t.Fatalf("Help for %q should not end with a period: %s", cmd, line)
 				}
 
-				// Options should not end with a space
+				// Options should NOT end with a space
 				if strings.HasSuffix(line, " ") {
 					t.Fatalf("Help for %q should not end with a space: %s", cmd, line)
 				}
+
 			}
 		}