Browse Source

Merge pull request #45391 from vvoland/windows-flaky-testkillcontainer

integration/TestKillContainer: Bigger timeout on Windows
Sebastiaan van Stijn 2 years ago
parent
commit
489543cd25
1 changed files with 7 additions and 1 deletions
  1. 7 1
      integration/container/kill_test.go

+ 7 - 1
integration/container/kill_test.go

@@ -2,6 +2,7 @@ package container // import "github.com/docker/docker/integration/container"
 
 
 import (
 import (
 	"context"
 	"context"
+	"runtime"
 	"testing"
 	"testing"
 	"time"
 	"time"
 
 
@@ -61,6 +62,11 @@ func TestKillContainer(t *testing.T) {
 		},
 		},
 	}
 	}
 
 
+	var pollOpts []poll.SettingOp
+	if runtime.GOOS == "windows" {
+		pollOpts = append(pollOpts, poll.WithTimeout(StopContainerWindowsPollTimeout))
+	}
+
 	for _, tc := range testCases {
 	for _, tc := range testCases {
 		tc := tc
 		tc := tc
 		t.Run(tc.doc, func(t *testing.T) {
 		t.Run(tc.doc, func(t *testing.T) {
@@ -70,7 +76,7 @@ func TestKillContainer(t *testing.T) {
 			err := client.ContainerKill(ctx, id, tc.signal)
 			err := client.ContainerKill(ctx, id, tc.signal)
 			assert.NilError(t, err)
 			assert.NilError(t, err)
 
 
-			poll.WaitOn(t, container.IsInState(ctx, client, id, tc.status), poll.WithDelay(100*time.Millisecond))
+			poll.WaitOn(t, container.IsInState(ctx, client, id, tc.status), pollOpts...)
 		})
 		})
 	}
 	}
 }
 }