diff --git a/daemon/logger/loggerutils/file_windows_test.go b/daemon/logger/loggerutils/file_windows_test.go index da1a9b92e4..f1201677d3 100644 --- a/daemon/logger/loggerutils/file_windows_test.go +++ b/daemon/logger/loggerutils/file_windows_test.go @@ -20,7 +20,7 @@ func TestOpenFileDelete(t *testing.T) { func TestOpenFileRename(t *testing.T) { tmpDir := t.TempDir() - f, err := openFile(filepath.Join(tmpDir, "test.txt"), os.O_CREATE|os.O_RDWR, 0644) + f, err := openFile(filepath.Join(tmpDir, "test.txt"), os.O_CREATE|os.O_RDWR, 0o644) assert.NilError(t, err) defer f.Close() @@ -30,7 +30,7 @@ func TestOpenFileRename(t *testing.T) { func TestUnlinkOpenFile(t *testing.T) { tmpDir := t.TempDir() name := filepath.Join(tmpDir, "test.txt") - f, err := openFile(name, os.O_CREATE|os.O_RDWR, 0644) + f, err := openFile(name, os.O_CREATE|os.O_RDWR, 0o644) assert.NilError(t, err) defer func() { assert.NilError(t, f.Close()) }() @@ -38,7 +38,7 @@ func TestUnlinkOpenFile(t *testing.T) { assert.NilError(t, err) assert.NilError(t, unlink(name)) - f2, err := openFile(name, os.O_CREATE|os.O_RDWR, 0644) + f2, err := openFile(name, os.O_CREATE|os.O_RDWR, 0o644) assert.NilError(t, err) defer func() { assert.NilError(t, f2.Close()) }() diff --git a/daemon/logger/loggerutils/logfile.go b/daemon/logger/loggerutils/logfile.go index 6cf358684c..51726b99a2 100644 --- a/daemon/logger/loggerutils/logfile.go +++ b/daemon/logger/loggerutils/logfile.go @@ -317,7 +317,7 @@ func compressFile(fileName string, lastTimestamp time.Time) (retErr error) { } }() - outFile, err := openFile(fileName+".gz", os.O_CREATE|os.O_TRUNC|os.O_RDWR, 0640) + outFile, err := openFile(fileName+".gz", os.O_CREATE|os.O_TRUNC|os.O_RDWR, 0o640) if err != nil { return errors.Wrap(err, "failed to open or create gzip log file") } diff --git a/daemon/logger/loggerutils/logfile_race_test.go b/daemon/logger/loggerutils/logfile_race_test.go index 25850d996d..b27e338b5b 100644 --- a/daemon/logger/loggerutils/logfile_race_test.go +++ b/daemon/logger/loggerutils/logfile_race_test.go @@ -44,7 +44,7 @@ func TestConcurrentLogging(t *testing.T) { ct := ct dir := t.TempDir() g.Go(func() (err error) { - logfile, err := NewLogFile(filepath.Join(dir, "log.log"), capacity, maxFiles, compress, createDecoder, 0644, getTailReader) + logfile, err := NewLogFile(filepath.Join(dir, "log.log"), capacity, maxFiles, compress, createDecoder, 0o644, getTailReader) if err != nil { return err } diff --git a/daemon/logger/loggerutils/logfile_test.go b/daemon/logger/loggerutils/logfile_test.go index 20a115c7a9..e410169fb1 100644 --- a/daemon/logger/loggerutils/logfile_test.go +++ b/daemon/logger/loggerutils/logfile_test.go @@ -128,7 +128,7 @@ func TestCheckCapacityAndRotate(t *testing.T) { 3, // maxFiles true, // compress createDecoder, - 0600, // perms + 0o600, // perms getTailReader, ) assert.NilError(t, err) diff --git a/daemon/logger/loggerutils/sharedtemp_test.go b/daemon/logger/loggerutils/sharedtemp_test.go index 40fbc07a9b..2c3c23426e 100644 --- a/daemon/logger/loggerutils/sharedtemp_test.go +++ b/daemon/logger/loggerutils/sharedtemp_test.go @@ -212,7 +212,7 @@ func TestSharedTempFileConverter(t *testing.T) { func createFile(t *testing.T, path string, content string) { t.Helper() - f, err := openFile(path, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0644) + f, err := openFile(path, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0o644) assert.NilError(t, err) _, err = io.WriteString(f, content) assert.NilError(t, err)