瀏覽代碼

fix gotestsum.installer installing wrong version

When using go modules, `go build` will always fetch the latest
version of the package, so ignores the version we previously `go get`'d.

Instead of running `go get` and `go build` separately, this patch uses
`go get` (without the `-d` option) to do it all in one step.

Given that this binary is only used for testing, and only used inside the
Dockerfile, we should consider inlining this step in the Dockerfile itself,
but keeping that separate for now.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 5 年之前
父節點
當前提交
441aff3a17
共有 1 個文件被更改,包括 1 次插入3 次删除
  1. 1 3
      hack/dockerfile/install/gotestsum.installer

+ 1 - 3
hack/dockerfile/install/gotestsum.installer

@@ -5,7 +5,5 @@
 install_gotestsum() (
 install_gotestsum() (
 	set -e
 	set -e
 	export GO111MODULE=on
 	export GO111MODULE=on
-	go get -d "gotest.tools/gotestsum@${GOTESTSUM_COMMIT}"
-	go build ${GO_BUILDMODE} -o "${PREFIX}/gotestsum" 'gotest.tools/gotestsum'
-
+	GOBIN="${PREFIX}" go get ${GO_BUILDMODE} "gotest.tools/gotestsum@${GOTESTSUM_COMMIT}"
 )
 )