Browse Source

Make sure we are trying to unmount a mounted /etc/resolv.conf

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
Alvaro Saurin 9 năm trước cách đây
mục cha
commit
41cc7c4d9d
1 tập tin đã thay đổi với 8 bổ sung2 xóa
  1. 8 2
      integration-cli/docker_cli_run_test.go

+ 8 - 2
integration-cli/docker_cli_run_test.go

@@ -1448,10 +1448,16 @@ func (s *DockerSuite) TestRunResolvconfUpdate(c *check.C) {
 	// This test case is meant to test monitoring resolv.conf when it is
 	// a regular file not a bind mounc. So we unmount resolv.conf and replace
 	// it with a file containing the original settings.
-	cmd := exec.Command("umount", "/etc/resolv.conf")
-	if _, err = runCommand(cmd); err != nil {
+	mounted, err := mount.Mounted("/etc/resolv.conf")
+	if err != nil {
 		c.Fatal(err)
 	}
+	if mounted {
+		cmd := exec.Command("umount", "/etc/resolv.conf")
+		if _, err = runCommand(cmd); err != nil {
+			c.Fatal(err)
+		}
+	}
 
 	//cleanup
 	defer func() {