Browse Source

Merge pull request #44296 from corhere/narrow-pkg-imports-validator

hack: allow pkg/ to import internal/ packages
Cory Snider 2 years ago
parent
commit
40429857c3
2 changed files with 7 additions and 1 deletions
  1. 1 0
      hack/make.ps1
  2. 6 1
      hack/validate/pkg-imports

+ 1 - 0
hack/make.ps1

@@ -263,6 +263,7 @@ Function Validate-PkgImports($headCommit, $upstreamCommit) {
         # Filter out what we are looking for
         # Filter out what we are looking for
         $imports = @() + $imports -NotMatch "^github.com/docker/docker/pkg/" `
         $imports = @() + $imports -NotMatch "^github.com/docker/docker/pkg/" `
                                   -NotMatch "^github.com/docker/docker/vendor" `
                                   -NotMatch "^github.com/docker/docker/vendor" `
+                                  -NotMatch "^github.com/docker/docker/internal" `
                                   -Match "^github.com/docker/docker" `
                                   -Match "^github.com/docker/docker" `
                                   -Replace "`n", ""
                                   -Replace "`n", ""
         $imports | ForEach-Object{ $badFiles+="$file imports $_`n" }
         $imports | ForEach-Object{ $badFiles+="$file imports $_`n" }

+ 6 - 1
hack/validate/pkg-imports

@@ -11,7 +11,12 @@ unset IFS
 badFiles=()
 badFiles=()
 for f in "${files[@]}"; do
 for f in "${files[@]}"; do
 	IFS=$'\n'
 	IFS=$'\n'
-	badImports=($(go list -e -f '{{ join .Deps "\n" }}' "$f" | sort -u | grep -vE '^github.com/docker/docker/pkg/' | grep -vE '^github.com/docker/docker/vendor' | grep -E '^github.com/docker/docker' || true))
+	badImports=($(go list -e -f '{{ join .Deps "\n" }}' "$f" | sort -u \
+		| grep -vE '^github.com/docker/docker/pkg/' \
+		| grep -vE '^github.com/docker/docker/vendor' \
+		| grep -vE '^github.com/docker/docker/internal' \
+		| grep -E '^github.com/docker/docker' \
+		|| true))
 	unset IFS
 	unset IFS
 
 
 	for import in "${badImports[@]}"; do
 	for import in "${badImports[@]}"; do