Przeglądaj źródła

Merge pull request #35965 from thaJeztah/fix-volume-create-statuscode

Return 400 status instead of 500 for empty volume create body
Vincent Demeester 7 lat temu
rodzic
commit
39377bb96d
1 zmienionych plików z 6 dodań i 0 usunięć
  1. 6 0
      api/server/router/volume/volume_routes.go

+ 6 - 0
api/server/router/volume/volume_routes.go

@@ -2,11 +2,14 @@ package volume
 
 import (
 	"encoding/json"
+	"errors"
+	"io"
 	"net/http"
 
 	"github.com/docker/docker/api/server/httputils"
 	"github.com/docker/docker/api/types/filters"
 	volumetypes "github.com/docker/docker/api/types/volume"
+	"github.com/docker/docker/errdefs"
 	"golang.org/x/net/context"
 )
 
@@ -45,6 +48,9 @@ func (v *volumeRouter) postVolumesCreate(ctx context.Context, w http.ResponseWri
 
 	var req volumetypes.VolumesCreateBody
 	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
+		if err == io.EOF {
+			return errdefs.InvalidParameter(errors.New("got EOF while reading request body"))
+		}
 		return err
 	}