cmd/dockerd: fix some minor issues in Windows implementation

- properly use filepath.Join() for Windows paths
- use getDaemonConfDir() to get the path for storing daemon.json
- return error instead of logrus.Fatal(). The logrus.Fatal() was a left-over
  from when Cobra was not used, and appears to have been missed in commit
  fb83394714a9797f8ca5a08023a89560ce6c4aa3, which did the conversion to Cobra.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

cmd/dockerd/daemon_windows.go

@@ -24,7 +24,7 @@ func setDefaultUmask() error {
 }
 
 func getDaemonConfDir(root string) (string, error) {
-	return filepath.Join(root, `\config`), nil
+	return filepath.Join(root, "config"), nil
 }
 
 // preNotifyReady sends a message to the host when the API is active, but before the daemon is

cmd/dockerd/docker_windows.go

@@ -15,7 +15,7 @@ func runDaemon(opts *daemonOptions) error {
 	// register the service.
 	stop, runAsService, err := initService(daemonCli)
 	if err != nil {
-		logrus.Fatal(err)
+		return err
 	}
 
 	if stop {
@@ -24,7 +24,11 @@ func runDaemon(opts *daemonOptions) error {
 
 	// Windows specific settings as these are not defaulted.
 	if opts.configFile == "" {
-		opts.configFile = filepath.Join(opts.daemonConfig.Root, `config\daemon.json`)
+		configDir, err := getDaemonConfDir(opts.daemonConfig.Root)
+		if err != nil {
+			return err
+		}
+		opts.configFile = filepath.Join(configDir, "daemon.json")
 	}
 	if runAsService {
 		// If Windows SCM manages the service - no need for PID files