Browse Source

Merge pull request #6487 from vbatts/vbatts-error_info

adding a little uniqueness, to wrapped errors.
Tibor Vass 11 năm trước cách đây
mục cha
commit
331ae9c0f8
2 tập tin đã thay đổi với 5 bổ sung5 xóa
  1. 1 1
      api/client/utils.go
  2. 4 4
      api/server/server.go

+ 1 - 1
api/client/utils.go

@@ -105,7 +105,7 @@ func (cli *DockerCli) call(method, path string, data interface{}, passAuthInfo b
 		if len(body) == 0 {
 		if len(body) == 0 {
 			return nil, resp.StatusCode, fmt.Errorf("Error: request returned %s for API route and version %s, check if the server supports the requested API version", http.StatusText(resp.StatusCode), req.URL)
 			return nil, resp.StatusCode, fmt.Errorf("Error: request returned %s for API route and version %s, check if the server supports the requested API version", http.StatusText(resp.StatusCode), req.URL)
 		}
 		}
-		return nil, resp.StatusCode, fmt.Errorf("Error: %s", bytes.TrimSpace(body))
+		return nil, resp.StatusCode, fmt.Errorf("Error response from daemon: %s", bytes.TrimSpace(body))
 	}
 	}
 	return resp.Body, resp.StatusCode, nil
 	return resp.Body, resp.StatusCode, nil
 }
 }

+ 4 - 4
api/server/server.go

@@ -398,7 +398,7 @@ func getContainersLogs(eng *engine.Engine, version version.Version, w http.Respo
 	job.Stdout.Add(outStream)
 	job.Stdout.Add(outStream)
 	job.Stderr.Set(errStream)
 	job.Stderr.Set(errStream)
 	if err := job.Run(); err != nil {
 	if err := job.Run(); err != nil {
-		fmt.Fprintf(outStream, "Error: %s\n", err)
+		fmt.Fprintf(outStream, "Error running logs job: %s\n", err)
 	}
 	}
 	return nil
 	return nil
 }
 }
@@ -811,7 +811,7 @@ func postContainersAttach(eng *engine.Engine, version version.Version, w http.Re
 	job.Stdout.Add(outStream)
 	job.Stdout.Add(outStream)
 	job.Stderr.Set(errStream)
 	job.Stderr.Set(errStream)
 	if err := job.Run(); err != nil {
 	if err := job.Run(); err != nil {
-		fmt.Fprintf(outStream, "Error: %s\n", err)
+		fmt.Fprintf(outStream, "Error attaching: %s\n", err)
 
 
 	}
 	}
 	return nil
 	return nil
@@ -841,7 +841,7 @@ func wsContainersAttach(eng *engine.Engine, version version.Version, w http.Resp
 		job.Stdout.Add(ws)
 		job.Stdout.Add(ws)
 		job.Stderr.Set(ws)
 		job.Stderr.Set(ws)
 		if err := job.Run(); err != nil {
 		if err := job.Run(); err != nil {
-			utils.Errorf("Error: %s", err)
+			utils.Errorf("Error attaching websocket: %s", err)
 		}
 		}
 	})
 	})
 	h.ServeHTTP(w, r)
 	h.ServeHTTP(w, r)
@@ -1022,7 +1022,7 @@ func makeHttpHandler(eng *engine.Engine, logging bool, localMethod string, local
 		}
 		}
 
 
 		if err := handlerFunc(eng, version, w, r, mux.Vars(r)); err != nil {
 		if err := handlerFunc(eng, version, w, r, mux.Vars(r)); err != nil {
-			utils.Errorf("Error: %s", err)
+			utils.Errorf("Error making handler: %s", err)
 			httpError(w, err)
 			httpError(w, err)
 		}
 		}
 	}
 	}