Browse Source

Merge pull request #45153 from neersighted/carry_45112

builder-next: disable mergeop and diffop
Bjorn Neergaard 2 years ago
parent
commit
2cf6389142
2 changed files with 18 additions and 0 deletions
  1. 3 0
      .github/workflows/buildkit.yml
  2. 15 0
      builder/builder-next/controller.go

+ 3 - 0
.github/workflows/buildkit.yml

@@ -70,6 +70,9 @@ jobs:
         name: Prepare
         run: |
           disabledFeatures="cache_backend_azblob,cache_backend_s3"
+          if [ "${{ matrix.worker }}" = "dockerd" ]; then
+            disabledFeatures="${disabledFeatures},merge_diff"
+          fi
           echo "BUILDKIT_TEST_DISABLE_FEATURES=${disabledFeatures}" >> $GITHUB_ENV
       -
         name: Checkout

+ 15 - 0
builder/builder-next/controller.go

@@ -49,6 +49,9 @@ import (
 	"github.com/pkg/errors"
 	"go.etcd.io/bbolt"
 	bolt "go.etcd.io/bbolt"
+
+	"github.com/moby/buildkit/solver/pb"
+	"github.com/moby/buildkit/util/apicaps"
 )
 
 func newController(ctx context.Context, rt http.RoundTripper, opt Opt) (*control.Controller, error) {
@@ -165,6 +168,18 @@ func newGraphDriverController(ctx context.Context, rt http.RoundTripper, opt Opt
 	dist := opt.Dist
 	root := opt.Root
 
+	pb.Caps.Init(apicaps.Cap{
+		ID:                pb.CapMergeOp,
+		Enabled:           false,
+		DisabledReasonMsg: "only enabled with containerd image store backend",
+	})
+
+	pb.Caps.Init(apicaps.Cap{
+		ID:                pb.CapDiffOp,
+		Enabled:           false,
+		DisabledReasonMsg: "only enabled with containerd image store backend",
+	})
+
 	var driver graphdriver.Driver
 	if ls, ok := dist.LayerStore.(interface {
 		Driver() graphdriver.Driver