diff --git a/libnetwork/drivers/overlay/ov_endpoint.go b/libnetwork/drivers/overlay/ov_endpoint.go index 1174d6b0eb..ba71a85ab4 100644 --- a/libnetwork/drivers/overlay/ov_endpoint.go +++ b/libnetwork/drivers/overlay/ov_endpoint.go @@ -42,10 +42,8 @@ func (n *network) deleteEndpoint(eid string) { n.Unlock() } -func (d *driver) CreateEndpoint(nid, eid string, ifInfo driverapi.InterfaceInfo, - epOptions map[string]interface{}) error { +func (d *driver) CreateEndpoint(nid, eid string, ifInfo driverapi.InterfaceInfo, epOptions map[string]interface{}) error { var err error - if err = validateID(nid, eid); err != nil { return err } diff --git a/libnetwork/drivers/overlay/ov_utils.go b/libnetwork/drivers/overlay/ov_utils.go index 80986bbc8a..e45b1a9396 100644 --- a/libnetwork/drivers/overlay/ov_utils.go +++ b/libnetwork/drivers/overlay/ov_utils.go @@ -47,7 +47,8 @@ func createVethPair() (string, string, error) { // Generate and add the interface pipe host <-> sandbox veth := &netlink.Veth{ LinkAttrs: netlink.LinkAttrs{Name: name1, TxQLen: 0}, - PeerName: name2} + PeerName: name2, + } if err := nlh.LinkAdd(veth); err != nil { return "", "", fmt.Errorf("error creating veth pair: %v", err) } diff --git a/libnetwork/drivers/overlay/overlay_test.go b/libnetwork/drivers/overlay/overlay_test.go index 24695550aa..5d28ac97b8 100644 --- a/libnetwork/drivers/overlay/overlay_test.go +++ b/libnetwork/drivers/overlay/overlay_test.go @@ -25,8 +25,7 @@ func (dt *driverTester) GetPluginGetter() plugingetter.PluginGetter { return nil } -func (dt *driverTester) RegisterDriver(name string, drv driverapi.Driver, - cap driverapi.Capability) error { +func (dt *driverTester) RegisterDriver(name string, drv driverapi.Driver, cap driverapi.Capability) error { if name != testNetworkType { dt.t.Fatalf("Expected driver register name to be %q. Instead got %q", testNetworkType, name) diff --git a/libnetwork/drivers/overlay/peerdb.go b/libnetwork/drivers/overlay/peerdb.go index f508593b48..f5792f96e8 100644 --- a/libnetwork/drivers/overlay/peerdb.go +++ b/libnetwork/drivers/overlay/peerdb.go @@ -154,7 +154,6 @@ func (d *driver) peerDbSearch(nid string, peerIP net.IP) (*peerKey, *peerEntry, return false }) - if err != nil { return nil, nil, fmt.Errorf("peerdb search for peer ip %q failed: %v", peerIP, err) } @@ -262,8 +261,7 @@ func (d *driver) peerInitOp(nid string) error { }) } -func (d *driver) peerAdd(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, - peerMac net.HardwareAddr, vtep net.IP, l2Miss, l3Miss, localPeer bool) { +func (d *driver) peerAdd(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, peerMac net.HardwareAddr, vtep net.IP, l2Miss, l3Miss, localPeer bool) { d.peerOpMu.Lock() defer d.peerOpMu.Unlock() err := d.peerAddOp(nid, eid, peerIP, peerIPMask, peerMac, vtep, l2Miss, l3Miss, true, localPeer) @@ -343,8 +341,7 @@ func (d *driver) peerAddOp(nid, eid string, peerIP net.IP, peerIPMask net.IPMask return nil } -func (d *driver) peerDelete(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, - peerMac net.HardwareAddr, vtep net.IP, localPeer bool) { +func (d *driver) peerDelete(nid, eid string, peerIP net.IP, peerIPMask net.IPMask, peerMac net.HardwareAddr, vtep net.IP, localPeer bool) { d.peerOpMu.Lock() defer d.peerOpMu.Unlock() err := d.peerDeleteOp(nid, eid, peerIP, peerIPMask, peerMac, vtep, localPeer) diff --git a/libnetwork/drivers/overlay/peerdb_test.go b/libnetwork/drivers/overlay/peerdb_test.go index dd412d0e85..1c10ebcce9 100644 --- a/libnetwork/drivers/overlay/peerdb_test.go +++ b/libnetwork/drivers/overlay/peerdb_test.go @@ -9,10 +9,12 @@ import ( func TestPeerMarshal(t *testing.T) { _, ipNet, _ := net.ParseCIDR("192.168.0.1/24") - p := &peerEntry{eid: "eid", + p := &peerEntry{ + eid: "eid", isLocal: true, peerIPMask: ipNet.Mask, - vtep: ipNet.IP} + vtep: ipNet.IP, + } entryDB := p.MarshalDB() x := entryDB.UnMarshalDB() if x.eid != p.eid {