diff --git a/daemon/container_operations.go b/daemon/container_operations.go index b0d3738989..0ae4f98a39 100644 --- a/daemon/container_operations.go +++ b/daemon/container_operations.go @@ -28,18 +28,6 @@ import ( "github.com/docker/go-connections/nat" ) -func (daemon *Daemon) getDNSSearchSettings(cfg *config.Config, container *container.Container) []string { - if len(container.HostConfig.DNSSearch) > 0 { - return container.HostConfig.DNSSearch - } - - if len(cfg.DNSSearch) > 0 { - return cfg.DNSSearch - } - - return nil -} - func (daemon *Daemon) buildSandboxOptions(cfg *config.Config, container *container.Container) ([]libnetwork.SandboxOption, error) { var ( sboxOptions []libnetwork.SandboxOption @@ -77,8 +65,12 @@ func (daemon *Daemon) buildSandboxOptions(cfg *config.Config, container *contain sboxOptions = append(sboxOptions, libnetwork.OptionDNS(d)) } - dnsSearch := daemon.getDNSSearchSettings(cfg, container) - + var dnsSearch []string + if len(container.HostConfig.DNSSearch) > 0 { + dnsSearch = container.HostConfig.DNSSearch + } else if len(cfg.DNSSearch) > 0 { + dnsSearch = cfg.DNSSearch + } for _, ds := range dnsSearch { sboxOptions = append(sboxOptions, libnetwork.OptionDNSSearch(ds)) } diff --git a/daemon/oci_windows.go b/daemon/oci_windows.go index 2dbbf69c57..00e4247ce1 100644 --- a/daemon/oci_windows.go +++ b/daemon/oci_windows.go @@ -112,8 +112,7 @@ func (daemon *Daemon) createSpec(ctx context.Context, daemonCfg *configStore, c mounts = append(mounts, secretMounts...) } - configMounts := c.ConfigMounts() - if configMounts != nil { + if configMounts := c.ConfigMounts(); configMounts != nil { mounts = append(mounts, configMounts...) } @@ -145,8 +144,6 @@ func (daemon *Daemon) createSpec(ctx context.Context, daemonCfg *configStore, c return nil, errors.Wrapf(err, "container %s", c.ID) } - dnsSearch := daemon.getDNSSearchSettings(&daemonCfg.Config, c) - // Get endpoints for the libnetwork allocated networks to the container var epList []string AllowUnqualifiedDNSQuery := false @@ -197,6 +194,13 @@ func (daemon *Daemon) createSpec(ctx context.Context, daemonCfg *configStore, c epList = append(epList, gwHNSID) } + var dnsSearch []string + if len(c.HostConfig.DNSSearch) > 0 { + dnsSearch = c.HostConfig.DNSSearch + } else if len(daemonCfg.DNSSearch) > 0 { + dnsSearch = daemonCfg.DNSSearch + } + s.Windows.Network = &specs.WindowsNetwork{ AllowUnqualifiedDNSQuery: AllowUnqualifiedDNSQuery, DNSSearchList: dnsSearch,