Browse Source

registry: remove TODO for removing localhost as insecure by default

While this was intended t be a stop-gap solution, it's been there for years and
users depend on this. It's also still complicated to secure _localhost_, so
by now, we'd probably have to be realistic, and consider this to be "permanent".

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 3 years ago
parent
commit
2bcf4628a7
1 changed files with 2 additions and 5 deletions
  1. 2 5
      registry/config.go

+ 2 - 5
registry/config.go

@@ -161,11 +161,8 @@ func (config *serviceConfig) LoadMirrors(mirrors []string) error {
 
 
 // LoadInsecureRegistries loads insecure registries to config
 // LoadInsecureRegistries loads insecure registries to config
 func (config *serviceConfig) LoadInsecureRegistries(registries []string) error {
 func (config *serviceConfig) LoadInsecureRegistries(registries []string) error {
-	// Localhost is by default considered as an insecure registry
-	// This is a stop-gap for people who are running a private registry on localhost (especially on Boot2docker).
-	//
-	// TODO: should we deprecate this once it is easier for people to set up a TLS registry or change
-	// daemon flags on boot2docker?
+	// Localhost is by default considered as an insecure registry. This is a
+	// stop-gap for people who are running a private registry on localhost.
 	registries = append(registries, "127.0.0.0/8")
 	registries = append(registries, "127.0.0.0/8")
 
 
 	// Store original InsecureRegistryCIDRs and IndexConfigs
 	// Store original InsecureRegistryCIDRs and IndexConfigs