Browse Source

Use Fprintf instead of Fprintln

Guillaume J. Charmes 12 years ago
parent
commit
279db68b46
2 changed files with 7 additions and 4 deletions
  1. 6 3
      api.go
  2. 1 1
      server.go

+ 6 - 3
api.go

@@ -437,7 +437,8 @@ func postImagesInsert(srv *Server, w http.ResponseWriter, r *http.Request) error
 	}
 	fmt.Fprintf(file, "HTTP/1.1 200 OK\r\nContent-Type: raw-stream-hijack\r\n\r\n")
 	if err := srv.ImageInsert(name, url, path, file); err != nil {
-		fmt.Fprintln(file, "Error: "+err.Error())
+		fmt.Fprintf(file, "Error: %s\n", err)
+		return err
 	}
 	return nil
 }
@@ -467,7 +468,8 @@ func postImagesPush(srv *Server, w http.ResponseWriter, r *http.Request) error {
 	}
 	fmt.Fprintf(file, "HTTP/1.1 200 OK\r\nContent-Type: raw-stream-hijack\r\n\r\n")
 	if err := srv.ImagePush(name, registry, file); err != nil {
-		fmt.Fprintln(file, "Error: "+err.Error())
+		fmt.Fprintln(file, "Error: $s\n", err)
+		return err
 	}
 	return nil
 }
@@ -488,7 +490,8 @@ func postBuild(srv *Server, w http.ResponseWriter, r *http.Request) error {
 	}
 	fmt.Fprintf(file, "HTTP/1.1 200 OK\r\nContent-Type: raw-stream-hijack\r\n\r\n")
 	if err := srv.ImageCreateFormFile(file); err != nil {
-		fmt.Fprintln(file, "Error: "+err.Error())
+		fmt.Fprintln(file, "Error: %s\n", err)
+		return err
 	}
 	return nil
 }

+ 1 - 1
server.go

@@ -342,7 +342,7 @@ func (srv *Server) ImageImport(src, repo, tag string, file *os.File) error {
 	} else {
 		u, err := url.Parse(src)
 		if err != nil {
-			fmt.Fprintln(file, "Error: "+err.Error())
+			fmt.Fprintf(file, "Error: %s\n", err)
 		}
 		if u.Scheme == "" {
 			u.Scheme = "http"