Explorar o código

Merge pull request #162 from thaJeztah/18.09_backport_38636_fix_nil_pointer_dereference

[18.09 backport] Fix nil pointer derefence on failure to connect to containerd
Tibor Vass %!s(int64=6) %!d(string=hai) anos
pai
achega
24c6c3eb52
Modificáronse 1 ficheiros con 2 adicións e 2 borrados
  1. 2 2
      libcontainerd/supervisor/remote_daemon.go

+ 2 - 2
libcontainerd/supervisor/remote_daemon.go

@@ -311,6 +311,8 @@ func (r *remote) monitorDaemon(ctx context.Context) {
 				delay = time.After(time.Duration(transientFailureCount) * 200 * time.Millisecond)
 				delay = time.After(time.Duration(transientFailureCount) * 200 * time.Millisecond)
 				continue
 				continue
 			}
 			}
+			client.Close()
+			client = nil
 		}
 		}
 
 
 		if system.IsProcessAlive(r.daemonPid) {
 		if system.IsProcessAlive(r.daemonPid) {
@@ -318,8 +320,6 @@ func (r *remote) monitorDaemon(ctx context.Context) {
 			r.killDaemon()
 			r.killDaemon()
 		}
 		}
 
 
-		client.Close()
-		client = nil
 		r.daemonPid = -1
 		r.daemonPid = -1
 		delay = nil
 		delay = nil
 		transientFailureCount = 0
 		transientFailureCount = 0