Browse Source

Merge pull request #41522 from thaJeztah/19.03_backport_gcp_leak

[19.03 backport] Fix gcplogs memory/connection leak
Brian Goff 4 years ago
parent
commit
233a6379e5
1 changed files with 3 additions and 1 deletions
  1. 3 1
      daemon/logger/gcplogs/gcplogging.go

+ 3 - 1
daemon/logger/gcplogs/gcplogging.go

@@ -53,6 +53,7 @@ func init() {
 }
 
 type gcplogs struct {
+	client    *logging.Client
 	logger    *logging.Logger
 	instance  *instanceInfo
 	container *containerInfo
@@ -169,6 +170,7 @@ func New(info logger.Info) (logger.Logger, error) {
 	}
 
 	l := &gcplogs{
+		client: c,
 		logger: lg,
 		container: &containerInfo{
 			Name:      info.ContainerName,
@@ -236,7 +238,7 @@ func (l *gcplogs) Log(m *logger.Message) error {
 
 func (l *gcplogs) Close() error {
 	l.logger.Flush()
-	return nil
+	return l.client.Close()
 }
 
 func (l *gcplogs) Name() string {