Browse Source

Merge pull request #38653 from sreis/38636-fix-nil-pointer-dereference

Fix nil pointer derefence on failure to connect to containerd
Sebastiaan van Stijn 6 years ago
parent
commit
22e4f12e5f
1 changed files with 2 additions and 2 deletions
  1. 2 2
      libcontainerd/supervisor/remote_daemon.go

+ 2 - 2
libcontainerd/supervisor/remote_daemon.go

@@ -311,6 +311,8 @@ func (r *remote) monitorDaemon(ctx context.Context) {
 				delay = time.After(time.Duration(transientFailureCount) * 200 * time.Millisecond)
 				continue
 			}
+			client.Close()
+			client = nil
 		}
 
 		if system.IsProcessAlive(r.daemonPid) {
@@ -318,8 +320,6 @@ func (r *remote) monitorDaemon(ctx context.Context) {
 			r.killDaemon()
 		}
 
-		client.Close()
-		client = nil
 		r.daemonPid = -1
 		delay = nil
 		transientFailureCount = 0