0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #45603 from thaJeztah/windows_notgo

Browse source 
hack/make/.binary: don't use "netgo" when building Windows binaries
This commit is contained in:
Sebastiaan van Stijn 2023-05-24 18:41:38 +02:00 • committed by GitHub
commit 1e3cdd3512
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
hack/make/.binary
View file

@ -51,6 +51,18 @@ source "${MAKEDIR}/.go-autogen"
fi
fi
# XXX: Disable netgo on Windows and use Window's system resolver instead.
#
# go1.19 and newer added support for netgo on Windows (https://go.dev/doc/go1.19#net),
# which won't ask Windows for DNS results, and hence may be ignoring
# custom "C:\Windows\System32\drivers\etc\hosts".
# See https://github.com/moby/moby/issues/45251#issuecomment-1561001817
# https://github.com/moby/moby/issues/45251, and
# https://go-review.googlesource.com/c/go/+/467335
if [ "$(go env GOOS)" = "windows" ]; then
BUILDFLAGS=("${BUILDFLAGS[@]/netgo/}")
fi
# only necessary for non-sandboxed invocation where TARGETPLATFORM is empty
PLATFORM_NAME=$TARGETPLATFORM
if [ -z "$PLATFORM_NAME" ]; then